Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Yarn configuration and GitHub Actions workflow to support a modern Yarn (Berry) + Corepack setup, along with related ignore rules for local Yarn artifacts.
Changes:
- Add a Yarn Berry config (
.yarnrc.yml) to use thenode-moduleslinker. - Update
.gitignoreto ignore Yarn 4 local artifacts (while allowing patches/plugins/releases to be committed if needed). - Modernize CI by using Node.js 22, enabling Corepack, adjusting caching, and switching to a Yarn 4-compatible install command.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .yarnrc.yml | Configures Yarn to use node-modules linker under Yarn 4. |
| .gitignore | Ignores Yarn Berry local artifacts to reduce repo noise. |
| .github/workflows/main.yml | Moves CI to Node 22 + Corepack and updates Yarn install/caching strategy. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+38
to
+44
| # setup-node's built-in `cache: yarn` is not used: it requires a committed | ||
| # lockfile, and yarn.lock is gitignored in this repo. | ||
| - name: Cache Yarn downloads | ||
| uses: actions/cache@v4 | ||
| id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`) | ||
| with: | ||
| path: ${{ steps.yarn-cache-dir-path.outputs.dir }} | ||
| key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | ||
| path: ~/.yarn/berry/cache | ||
| key: ${{ runner.os }}-yarn-${{ hashFiles('package.json') }} |
Comment on lines
+27
to
+31
| - name: Set up Node | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '22' | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modernizes and improves the authentication flow and developer experience for the project. The main changes upgrade the Node.js and Yarn toolchain for CI, fix session validation and expiry logic, and enhance user feedback for login errors. The changes also ensure consistent session state and error reporting in the UI.
CI and Toolchain Modernization:
.github/workflows/main.yml,.yarnrc.yml,package.json) [1] [2] [3]Authentication and Session Handling Improvements:
src/stores/auth.store.js) (F54360afL24R24, [1] [2] [3]src/stores/auth.store.js)User Feedback and UI Enhancements:
OrcidLogincomponent, reset errors on new login attempts, and displayed human-readable error messages to users when login is refused. (src/views/pagedecorators/headercomponents/OrcidLogin.vue) [1] [2] [3]src/views/pagedecorators/headercomponents/OrcidLogin.vue)