Print argv at the top for all benchmarking runs - #463
Conversation
|
@coderabbitai full review |
✅ Action performedFull review finished. |
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesThe printer API now supports command-line output. Markdown printers store and quote arguments, multiplexed printers forward output, and Command-line output
Suggested reviewers: Merge Risk: 🔵 Low · up to The change improves benchmark report reproducibility, but certain arguments can produce malformed Markdown, copied commands may be wrong on Windows, and custom argument handlers may cause the displayed command to differ from what the user entered. The PR is mergeable with explicit owner follow-up on these bounded correctness issues. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 5b9aa6b7-d065-48f3-8fb0-42c2b1bb9804
📒 Files selected for processing (7)
README.mdnvbench/main.cuhnvbench/markdown_printer.cunvbench/markdown_printer.cuhnvbench/printer_base.cuhnvbench/printer_multiplex.cuhnvbench/printer_multiplex.cxx
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.
Print the command line as the script saw it at the header of each benchmarking run.
For example, in the markdown printer:
$ ./my_bench --foo --bar -baz=bop ... # Command Line ./my_bench --foo --bar -baz=bop