fix: derive third-party notices base image from Dockerfile - #212
Open
git-jxj wants to merge 1 commit into
Open
Conversation
Signed-off-by: xinjun.jiang <xinjun.jiang@daocloud.io>
git-jxj
force-pushed
the
fix/derive-notices-base-image
branch
from
September 9, 2026 06:51
6d48e0c to
48f1890
Compare
Author
|
The current head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notices generator hardcodes distroless Go v4.0.2 even though the runtime Dockerfile now uses v4.1.1. Regenerating the notices therefore preserves the stale image name and source-index URL.
Read the image from the Dockerfile's final
FROMand derive both fields from its version tag. Tagged digest references preserve the full image reference while using the tag for the source index. Unsupported references fail with an explicit error instead of producing incorrect notices. RegenerateTHIRD_PARTY_NOTICES.md; only those two fields change.Fixes #210.
Validation:
make noticesandmake notices-check.bash -n tools/generate-notices.sh,shellcheck -e SC2016 tools/generate-notices.sh(Markdown backticks in single-quoted strings are intentional), and parser cases covering unsupported references.