Skip to content

Disable -Wunused-template for clang - #11069

Merged
davebayer merged 1 commit into
NVIDIA:mainfrom
Jacobfaib:jacobf/2026-08-31/disable-clang-wunused-template
Aug 31, 2026
Merged

Disable -Wunused-template for clang#11069
davebayer merged 1 commit into
NVIDIA:mainfrom
Jacobfaib:jacobf/2026-08-31/disable-clang-wunused-template

Conversation

@Jacobfaib

Copy link
Copy Markdown
Contributor

Description

See llvm/llvm-project#219968

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Jacobfaib
Jacobfaib requested a review from a team as a code owner August 31, 2026 13:40
@Jacobfaib
Jacobfaib requested a review from wmaxey August 31, 2026 13:40
@github-project-automation github-project-automation Bot moved this to Todo in CCCL Aug 31, 2026
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Review in CCCL Aug 31, 2026
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 185cc2d0-0414-475a-bebf-26be6866eee6

📥 Commits

Reviewing files that changed from the base of the PR and between 79a4e5c and 569e6d9.

📒 Files selected for processing (1)
  • cmake/CCCLBuildCompilerTargets.cmake

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Reduced unnecessary compiler warnings during builds where the option is supported.
    • Improved compatibility with current compiler toolchains and GPU kernel builds.

Walkthrough

Changes

Compiler warning configuration

Layer / File(s) Summary
Unused-template warning configuration
cmake/CCCLBuildCompilerTargets.cmake
The CMake configuration checks whether -Wunused-template is available before disabling it for C++ compilation. Comments document LLVM 23 and NVCC GPU kernel call stub behavior.

Suggested reviewers: bernhardmgruber, davebayer, gevtushenko, griwes, jrhemstad

Merge Risk: ⚪ Minimal · up to 569e6

This PR makes a localized compiler-warning configuration change, and no actionable merge-blocking risk remains beyond normal checks and review.


Comment @coderabbitai help to get the list of available commands.

@Jacobfaib Jacobfaib changed the title Disable -Wunused-template for clang Disable -Wunused-template for clang Aug 31, 2026
@Jacobfaib
Jacobfaib requested review from davebayer and miscco August 31, 2026 14:30
@github-actions

Copy link
Copy Markdown
Contributor

🥳 CI Workflow Results

🟩 Finished in 3h 13m: Pass: 100%/609 | Total: 22d 13h | Max: 3h 11m | Hits: 25%/2953091

See results here.

@davebayer
davebayer merged commit eaae7cb into NVIDIA:main Aug 31, 2026
640 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in CCCL Aug 31, 2026
@Jacobfaib
Jacobfaib deleted the jacobf/2026-08-31/disable-clang-wunused-template branch August 31, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants