Skip to content

Fix more _CCCL_DEVICE static -> _CCCL_DEVICE_API - #11068

Merged
davebayer merged 4 commits into
NVIDIA:mainfrom
Jacobfaib:jacobf/2026-08-31/more-static-fixes
Aug 31, 2026
Merged

Fix more _CCCL_DEVICE static -> _CCCL_DEVICE_API#11068
davebayer merged 4 commits into
NVIDIA:mainfrom
Jacobfaib:jacobf/2026-08-31/more-static-fixes

Conversation

@Jacobfaib

Copy link
Copy Markdown
Contributor

Description

More LLVM23 -Wunused-template warnings. After this round of fixes, however, we should just disable the warning entirely.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Jacobfaib
Jacobfaib requested review from a team as code owners August 31, 2026 13:31
@Jacobfaib
Jacobfaib requested a review from wmaxey August 31, 2026 13:31
@Jacobfaib
Jacobfaib requested a review from pauleonix August 31, 2026 13:31
@github-project-automation github-project-automation Bot moved this to Todo in CCCL Aug 31, 2026
@Jacobfaib
Jacobfaib requested a review from miscco August 31, 2026 13:32
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Review in CCCL Aug 31, 2026
@Jacobfaib Jacobfaib changed the title Fix more _CCCL_DEVICE static -> _CCCL_DEVICE_API Fix more _CCCL_DEVICE static -> _CCCL_DEVICE_API Aug 31, 2026
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • libcudacxx/include/cuda/std/__atomic/functions/cuda_ptx_generated.h
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 63278e33-303a-414c-acf0-a7051180f863

📥 Commits

Reviewing files that changed from the base of the PR and between cb688b8 and e4dc70c.

📒 Files selected for processing (1)
  • libcudacxx/include/cuda/std/__atomic/functions/cuda_ptx_generated.h

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b241ebe1-18d3-4315-827b-b091e19c955d

📥 Commits

Reviewing files that changed from the base of the PR and between 6864b6a and cb688b8.

📒 Files selected for processing (5)
  • libcudacxx/codegen/generators/compare_and_swap.h
  • libcudacxx/codegen/generators/exchange.h
  • libcudacxx/codegen/generators/fence.h
  • libcudacxx/codegen/generators/fetch_ops.h
  • libcudacxx/include/cuda/std/__atomic/functions/cuda_ptx_generated.h

Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved compatibility for CUDA dispatch, atomic, load/store, and synchronization helpers.
    • Enabled broader use of these helpers across compilation units and supported toolchains.
    • Preserved existing interfaces, runtime behavior, memory-order handling, and dispatch logic.
    • Standardized API exposure for device and runtime helper functions, including top-k, histogram, reduction, run-length encoding, and transform operations.

Walkthrough

Changes

CUB dispatch declarations and CUDA atomic helper declarations no longer use internal linkage. Function parameters, dispatch logic, atomic operations, and fence behavior remain unchanged.

CUB and CUDA helper linkage updates

Layer / File(s) Summary
CUB dispatch linkage
cub/cub/detail/env_dispatch.cuh, cub/cub/device/...
Environment, TopK, histogram, reduce-by-key, RLE, and transform dispatch functions no longer use static.
Generated atomic load and store linkage
libcudacxx/codegen/generators/ld_st.h
Generated atomic load and store helpers, dispatchers, functors, and wrappers now use _CCCL_DEVICE_API.
Generated atomic operation linkage
libcudacxx/codegen/generators/compare_and_swap.h, libcudacxx/codegen/generators/exchange.h, libcudacxx/codegen/generators/fetch_ops.h
Generated compare-exchange, exchange, and fetch-operation helpers now use _CCCL_DEVICE_API.
CUDA atomic helper linkage
libcudacxx/include/cuda/std/__atomic/functions/cuda_ptx_derived.h, libcudacxx/include/cuda/std/__atomic/platform/msvc_to_builtins.h
Atomic operations and fence helpers no longer use internal linkage. Their implementations remain unchanged.
Generated fence linkage
libcudacxx/codegen/generators/fence.h
Generated membar, fence, and thread-fence functions now use _CCCL_DEVICE_API.

Suggested reviewers: miscco, wmaxey, griwes

Merge Risk: ⚪ Minimal · up to cb688

This PR makes localized annotation changes to address compiler warnings, and no actionable merge-blocking risk remains beyond normal checks and review.


Comment @coderabbitai help to get the list of available commands.

@Jacobfaib
Jacobfaib requested a review from davebayer August 31, 2026 17:09
@Jacobfaib Jacobfaib self-assigned this Aug 31, 2026
@github-actions

This comment has been minimized.

@davebayer
davebayer enabled auto-merge (squash) August 31, 2026 17:15
@github-actions

Copy link
Copy Markdown
Contributor

🥳 CI Workflow Results

🟩 Finished in 3h 13m: Pass: 100%/405 | Total: 16d 21h | Max: 2h 52m | Hits: 31%/2206446

See results here.

@davebayer
davebayer merged commit d48604d into NVIDIA:main Aug 31, 2026
859 of 864 checks passed
@Jacobfaib
Jacobfaib deleted the jacobf/2026-08-31/more-static-fixes branch August 31, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants