Update publish-conda to use the new tag for the package version#922
Open
ceblanton wants to merge 1 commit into
Open
Update publish-conda to use the new tag for the package version#922ceblanton wants to merge 1 commit into
ceblanton wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #922 +/- ##
=======================================
Coverage 82.09% 82.09%
=======================================
Files 67 67
Lines 3736 3736
=======================================
Hits 3067 3067
Misses 669 669
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Run the publish-conda action on pushes to main or after the update-tag action has run.
We detect the latter case by a closed pull request on a main push AND the if-condition that checks that the source branch is the one triggered by the update-tag reference changes.
The "Set version for tagged release" is needed to inform conda-build of the tag. Because there are intermediate commits (the updated version refs) the commit no longer is tagged. So we can retrieve the package version from init.py
Issue ticket number and link (if applicable)
Fixes #921
Checklist before requesting a review
Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the
release_procedure.mdtemplate. To quickly use this template, open a new pull request, choose your branch, and add?template=release_procedure.mdto the end of the url.