Repository navigation
fix: keep bottom of profile page above the navigation bar - #1935
Open
paramveeRana wants to merge 1 commit into
Open
paramveeRana wants to merge 1 commit into
paramveeRana wants to merge 1 commit into
Conversation
The bottom padding is removed from the MediaQuery further up the tree, so the last items of the profile/settings page were drawn under the Android navigation buttons on some devices. Pad the list by the system navigation bar height. Closes NIAEFEUP#1915
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1915
The bottom padding is removed from the MediaQuery higher up, so the end of the profile/settings page was drawn under the Android navigation buttons. This pads the list by the system navigation bar height.
Before / after (Android, 3-button navigation):
