ufs-dev PR#377 RRFS smoke fix#1230
Open
scrasmussen wants to merge 214 commits into
Open
Conversation
…emove *_of_new_state (default name refers to 'current' value)
…medmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post
- Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes. - Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies. - Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables. - Removed redundant saved variables (`save_u`, `save_v`, `save_t`). - Added `delt` to post interstitials.
…' into feature/tendency_cleanup
…_dimension in GFS_time_vary_pre.scm
…endency paradigm; cleanup saving of states no longer needed
…as removed recently
…ke the ascii format
…ke the ascii format 2
…ke the ascii format 3
… to have suffix _ccpp and _mpas respectively
…ure moisture conservation
…_ufs_dev Metadata corrections from Fortran vs Metadata validation (ufs/dev version)
scrasmussen
requested review from
dustinswales,
grantfirl,
haiqinli and
rhaesung
as code owners
July 9, 2026 16:48
hertneky
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR catches the NCAR:main branch up with changes from the ufs-community:ufs/dev branch.
Associated ufs/dev PR:
Associated ufsatm PR:
Associated ufs-weather-model PR:
Associated NCAR SCM PR:
NOTE: PR #1228 used
cherry-pickinstead ofmergewhich meant that ufs-community#377 couldn't simply be merged. I usedgit merge --no-ff -s ours lisa/c3to fix the histories so this and future ufs/dev PRs can be merged. This command means there are lots of commits added, but one file changed.REGRESSION TEST CHANGES: The SCM tests fail in the SCM Github CI for the GNU Debug dev build : NCAR/ccpp-scm#708
I have confirmed though that this exact build works on Derecho, so this is more likely a corner case in the Github CI that needs to be fixed.