Skip to content

rdoq: skip uncoded cost setup for trailing zero groups #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiujunwang-dev wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −8
Open

rdoq: skip uncoded cost setup for trailing zero groups #990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions source/common/quant.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,20 +717,26 @@ uint32_t Quant::rdoQuant(const CUData &cu, int16_t *dstCoeff, TextType ttype, ui
uint32_t scanPos = 0;
uint32_t c1 = 1;

/* Initialize the uncoded distortion for every coefficient. This lets the
* coefficient loop replace uncoded costs with coded costs as needed. */
/* Trailing zero groups have the same distortion in every candidate,
* including CBF=0, so omit that common additive cost. Coefficients remain
* in raster order; use the existing 4x4-group primitives. */
for (int cg = 0; cg <= cgLastScanPos; cg++)
{
const uint32_t group = scanCG[cg];
const uint32_t base = ((group >> log2TrSizeCG) * trSize +
(group & (cgStride - 1))) * 4;
if (usePsyMask)
primitives.cu[log2TrSize - 2].psyRdoQuant(m_resiDctCoeff, sourceDct, costUncoded, &totalUncodedCost, &totalRdCost, &psyScale, base);
else
primitives.cu[log2TrSize - 2].nonPsyRdoQuant(m_resiDctCoeff, costUncoded, &totalUncodedCost, &totalRdCost, base);
}
if (usePsyMask)
{
primitives.cu[log2TrSize - 2].psyRdoQuantAll(m_resiDctCoeff, sourceDct, costUncoded, &totalUncodedCost, &totalRdCost, &psyScale);

/* DC distortion does not include the psy-RDOQ reconstruction bias. */
int64_t dcPsyCost = PSYVALUE(sourceDct[0] - m_resiDctCoeff[0]);
const int64_t dcPsyCost = PSYVALUE(sourceDct[0] - m_resiDctCoeff[0]);
costUncoded[0] += dcPsyCost;
totalUncodedCost += dcPsyCost;
totalRdCost += dcPsyCost;
}
else
primitives.cu[log2TrSize - 2].nonPsyRdoQuantAll(m_resiDctCoeff, costUncoded, &totalUncodedCost, &totalRdCost);
/* iterate over coding groups in reverse scan order */
for (int cgScanPos = cgLastScanPos; cgScanPos >= 0; cgScanPos--)
{
Expand Down
Loading