Repository navigation
Reuse local RDOQ rate costs and entropy flags - #989
Open
xiujunwang-dev wants to merge 1 commit into
Open
xiujunwang-dev wants to merge 1 commit into
xiujunwang-dev wants to merge 1 commit into
Conversation
Cache the coefficient-group scan base and zero-significance cost, and pass the used level-absolute bit cost directly to the local rate helpers. Reuse CBF queries within transform and coefficient coding. The aim is to reduce redundant local work while preserving coding decisions. Test results against unmodified master f2cf32d on macOS arm64 with AppleClang 21: - 8-bit Release: 8 cases of 240 frames; all bitstreams match the baseline. - 10-bit Release: 4 cases of 240 frames; all bitstreams match the baseline. - 8-bit CHECKED_BUILD=ON: 2 cases of 240 frames; bitstreams match and no assertions fail. All 14 comparisons pass byte for byte. Synthetic inputs cover RDOQ 1/2, 4:2:0/4:2:2/4:4:4, 8-bit monochrome, intra/inter coding, QP/CRF, psy-RDOQ and sign hiding. Checked-build cases cover 4:2:0 and 4:2:2. Build-info SEI is disabled with --no-info for bitstream comparisons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache the coefficient-group scan base and zero-significance cost, and pass the used level-absolute bit cost directly to the local rate helpers. Reuse CBF queries within transform and coefficient coding. The aim is to reduce redundant local work while preserving coding decisions.
Test results against unmodified master f2cf32d on macOS arm64 with AppleClang 21:
All 14 comparisons pass byte for byte. Synthetic inputs cover RDOQ 1/2, 4:2:0/4:2:2/4:4:4, 8-bit monochrome, intra/inter coding, QP/CRF, psy-RDOQ and sign hiding. Checked-build cases cover 4:2:0 and 4:2:2. Build-info SEI is disabled with --no-info for bitstream comparisons.