Skip to content

[fix] 카드 탭 지연을 없애고 버튼 hover가 터치 누름 피드백을 덮지 않게 한다 #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seongwon030 wants to merge 2 commits into
base: develop-fe
Choose a base branch
from
Open

[fix] 카드 탭 지연을 없애고 버튼 hover가 터치 누름 피드백을 덮지 않게 한다 #2259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa117c6
fix: 동아리 카드를 누르면 150ms 기다리지 않고 바로 상세로 이동한다
seongwon030 Oct 28, 2026
29987e7
fix: 공통 Button의 hover를 (hover: hover)로 감싸 터치 누름 피드백을 덮지 않게 한다
seongwon030 Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions frontend/src/components/common/Button/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,15 @@ const StyledButton = styled.button<{ $animated: boolean; $width?: string }>`
transition: background-color 0.2s;
width: ${({ $width }) => $width ?? 'auto'};

&:hover:not(:disabled) {
background-color: ${({ theme }) => theme.colors.gray[800]};
${({ $animated }) =>
$animated &&
css`
animation: ${pulse} 0.4s ease-in-out;
`}
@media (hover: hover) {
&:hover:not(:disabled) {
background-color: ${({ theme }) => theme.colors.gray[800]};
${({ $animated }) =>
$animated &&
css`
animation: ${pulse} 0.4s ease-in-out;
`}
}
}

&:active:not(:disabled) {
Expand Down
5 changes: 1 addition & 4 deletions frontend/src/pages/MainPage/components/ClubCard/ClubCard.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ const CARD_STYLES = {

const CardContainer = styled.div<{
$state: string;
$isClicked: boolean;
}>`
width: 100%;
display: flex;
Expand All @@ -34,7 +33,6 @@ const CardContainer = styled.div<{
transition:
transform 0.2s ease-in-out,
box-shadow 0.2s ease-in-out;
transform: ${({ $isClicked }) => ($isClicked ? 'scale(1.05)' : 'scale(1)')};
cursor: pointer;
touch-action: manipulation;

Expand All @@ -47,8 +45,7 @@ const CardContainer = styled.div<{

@media (hover: hover) {
&:hover {
transform: ${({ $isClicked }) =>
$isClicked ? 'scale(1.05)' : 'scale(1.03)'};
transform: scale(1.03);
}
}

Expand Down
18 changes: 6 additions & 12 deletions frontend/src/pages/MainPage/components/ClubCard/ClubCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useEffect, useRef, useState } from 'react';
import { useEffect, useRef } from 'react';
import { useNavigate } from 'react-router-dom';
import default_profile_image from '@/assets/images/logos/default_profile_image.svg';
import ClubStateBox from '@/components/ClubStateBox/ClubStateBox';
Expand Down Expand Up @@ -31,7 +31,6 @@ const ClubCard = ({
}: ClubCardProps) => {
const navigate = useNavigate();
const trackEvent = useMixpanelTrack();
const [isClicked, setIsClicked] = useState(false);
const containerRef = useRef<HTMLDivElement>(null);

const SS_LAST_KEY = `clubcard_last_${page ?? 'default'}_${club.id}`;
Expand Down Expand Up @@ -102,7 +101,6 @@ const ClubCard = ({
}, [club.id, club.name, club.recruitmentStatus, page]);

const handleClick = () => {
setIsClicked(true);
trackEvent(USER_EVENT.CLUB_CARD_CLICKED, {
club_id: club.id,
club_name: club.name,
Expand All @@ -118,21 +116,17 @@ const ClubCard = ({
device_type: getDeviceType(),
});

setTimeout(() => {
setIsClicked(false);
if (onCardClick) {
onCardClick(club);
} else {
navigate(`/clubDetail/@${encodeURIComponent(club.name)}`);
}
}, 150);
if (onCardClick) {
onCardClick(club);
} else {
navigate(`/clubDetail/@${encodeURIComponent(club.name)}`);
}
};

return (
<Styled.CardContainer
ref={containerRef}
$state={club.recruitmentStatus}
$isClicked={isClicked}
onClick={handleClick}
>
<Styled.CardHeader>
Expand Down
Loading