Enhance logging and task execution handling in Android - #1
Merged
Conversation
… background coroutine
There was a problem hiding this comment.
Pull request overview
This PR updates the core multiplatform logger to queue log/appender operations on a single-threaded coroutine worker, adds lazy message overloads for log calls, and tweaks platform appenders and build toolchain settings.
Changes:
- Replaces mutex/runBlocking synchronization in
LOGwith a coroutine/Channel-backed serial work queue and adds lambda-based logging overloads. - Adjusts Apple/Android appenders’ formatting behavior (stack trace concatenation; chunk splitting output).
- Updates Gradle JVM toolchain from 8 to 11.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
src/commonMain/kotlin/com/mindera/lodge/LOG.kt |
Serializes add/remove/log operations via a coroutine worker; adds lazy-message overloads; deduplicates appenders by loggerId. |
src/appleMain/kotlin/com/mindera/lodge/appenders/OSAppender.kt |
Combines message + stack trace into a single OS log call. |
src/androidMain/kotlin/com/mindera/lodge/appenders/LogcatAppender.kt |
Simplifies chunk splitting logic for long messages. |
build.gradle.kts |
Moves compilation toolchain to JDK 11. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…severity initials
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.