miv_rv32_version update fix#34
Open
elizabethjt wants to merge 4 commits into
Open
Conversation
ManuelSaldana
approved these changes
Jun 11, 2026
jennifermah76
requested changes
Jun 11, 2026
Collaborator
There was a problem hiding this comment.
Actually, could you really quick try the original demo design w/ this change? Does it rely on the variable you changed in this PR? (Like I'm wondering if this line will still work. I could be wrong but if you could check that would be great)
Collaborator
Author
As you mentioned this did happen, Ill edit it to match the change and test again. Thanks for noticing! |
ManuelSaldana
approved these changes
Jun 12, 2026
jennifermah76
approved these changes
Jun 12, 2026
jennifermah76
left a comment
jennifermah76
left a comment
Collaborator
There was a problem hiding this comment.
If both designs work on board, then it looks good to me. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.