Skip to content

fix: Improve logging of unhandled errors #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrederikBolding merged 1 commit into from
Oct 6, 2026
Merged

fix: Improve logging of unhandled errors #4135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/snaps-controllers/src/services/ExecutionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export type SnapExecutionData = {
export type SnapErrorJson = {
message: string;
code: number;
data?: Json;
data?: Record<string, Json>;
};

export type ExecutionServiceUnhandledErrorEvent = {
Expand Down
5 changes: 4 additions & 1 deletion packages/snaps-controllers/src/snaps/SnapController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1840,7 +1840,10 @@ export class SnapController extends BaseController<
_onUnhandledSnapError(snapId: string, error: SnapErrorJson) {
// Log the error that caused the crash
// so it gets raised to the developer for debugging purposes.
logError(`Unhandled error from "${snapId}":`, error);
logError(
`Unhandled error from "${snapId}":`,
getErrorMessage(error.data?.cause ?? error),
);
this.stopSnap(snapId as SnapId, SnapStatusEvents.Crash).catch(
(stopSnapError) => {
// TODO: Decide how to handle errors.
Expand Down
Loading