Repository navigation
feat(perps): regenerate the Perps review and add Extension and Core platform overlays - #192
Open
abretonc7s wants to merge 10 commits into
Open
abretonc7s wants to merge 10 commits into
abretonc7s wants to merge 10 commits into
Conversation
Adds the missing-numeric-data family and the delayed balance tracker rule.
A later source's directory without skill.md replaced an earlier source's skill during resolution, then got skipped, so the skill never installed (consensys testing/mobile-testing shadowed the public mobile-testing). Prune-stale now also removes unprefixed symlink aliases of managed skills, such as recipe-cook -> mms-recipe-cook.
Run the alias pass before the stale pass and treat a dangling sibling mms-* link as an alias, so switching to a smaller selection with --prune-stale no longer leaves recipe-cook -> mms-recipe-cook dangling. Cover later-source overrides and aliases in every destination.
Carries the remaining repo knowledge from the Farmslot farm fixtures into the skills: the Extension feature-flag registry is synced from production and E2E flag seeds must match the /v1/flags mock; Core tests both API failure shapes and judges public type changes by AGENTS.md.
# Conflicts: # CHANGELOG.md
…character budget The full skill audit runs when the installer changes and rejects the 1341-character description; the trimmed one keeps every defect class and the main triggers.
abretonc7s
marked this pull request as ready for review
October 6, 2026 18:12
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings the Perps review and two platform skills up to date with what MetaMask's development runs need, so per-repo agent fixtures outside this repository can be retired.
perps-review-pr): regenerated fromMetaMask/experimental-metamask-recipe-perps@f9f8cb9(branchdocs/preserve-missing-perps-values) withscripts/materialize-review.mjs. The library update keeps missing values visible and invokes the domain self-review, replaces the removed MYX provider with Lighter, states one formatting rule (formatPerpsFiatfor displayed fiat values), points shared utils and services at@metamask/perps-controllerinstead of a drifting list, and adds that Mobiledocs/perps/pages change with the pattern they document.feature-flags, new MetaMask Extension overlay: names the shared helper, the production-synced E2E registry (reuse synced entries, pre-launch keys withinProd: false), and the E2E override order (manifestFlags.remoteFeatureFlagsfirst; fixture state plus the/v1/flagsmock only for code that readsRemoteFeatureFlagControllerstate directly).controller-guidelines, new Core overlay: test both API failure shapes; classify a public type change byAGENTS.md.ab-testingExtension overlay: the staleFixtureBuilder.withRemoteFeatureFlagsoverride line now points at the feature-flags overlay.skill.md, and prune unprefixed aliases before their targets during--prune-stale.Type of Change
Checklist
Testing
node --test test/*.test.mjs: 76 pass (new install cases for alias pruning and skill.md-less directories).yarn lint:changelogpasses;lint-skill-entryreports no errors (thetsc-blindspotsdescription is trimmed to the 1024-character budget, which the full-audit run triggered by the installer change enforces).materialize-review.mjs --checkverifiesperps-review-pragainst the library atf9f8cb9.mainof metamask-extension and core.Additional Context
Companion changes: Consensys/skills#92 (Recipe Cook dev and fix-bug templates) and the perps library branch
docs/preserve-missing-perps-values.