Repository navigation
chore: replace ESLint with Oxlint - #349
Conversation
e27981c to
8588163
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
8588163 to
e42b58e
Compare
e42b58e to
0734fcd
Compare
0734fcd to
9070cd5
Compare
9070cd5 to
5c914cf
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Reviewed by Cursor Bugbot for commit 5c914cf. Configure here.
| "@yarnpkg/shell", | ||
| "eslint-config-*", | ||
| "eslint-import-resolver-typescript", | ||
| "eslint-plugin-*", |
There was a problem hiding this comment.
Depcheck ignores miss oxlint packages
Medium Severity
The ignore list dropped the eslint-plugin-* wildcard and never added oxlint-tsgolint, so eslint-plugin-n and oxlint-tsgolint look unused to depcheck. yarn lint:dependencies fails even though both packages are required peers of the oxlint configs.
Reviewed by Cursor Bugbot for commit 5c914cf. Configure here.
| "@metamask/oxlint-config-typescript": "^0.1.1", | ||
| "@metamask/oxlint-config-vitest": "^0.1.1", | ||
| "@types/node": "^18.18", | ||
| "@typescript-eslint/utils": "^8.6.0", |
There was a problem hiding this comment.
Unused Vitest ESLint plugin remains
Low Severity
@vitest/eslint-plugin remains in devDependencies after the ESLint removal, but @metamask/oxlint-config-vitest does not depend on it, so the package is unused.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 5c914cf. Configure here.


This replaces ESLint with Oxlint, with the intention of matching the ESLint config as closely as possible.
Examples
MetaMask/core#10151
Note
Medium Risk
Large dev-tooling swap can change which issues CI catches versus ESLint, though application/runtime code is untouched.
Overview
Swaps the module template’s primary linter from ESLint to Oxlint, aligned with MetaMask’s shared
@metamask/oxlint-config*packages.eslint.config.mjsis removed andoxlint.config.tsis added with file-based overrides for TypeScript, CommonJS/Node (including scripts and.github), and Vitest/tests, plus type-aware linting viaoxlint-tsgolint.lint/lint:fixnow runlint:oxlintinstead oflint:eslint, and Lavamoat script config is updated to match.Dev dependencies drop the ESLint core stack (
eslint,@metamask/eslint-config-*,typescript-eslint, import/jsdoc/prettier plugins, etc.) in favor ofoxlintand the new config packages;eslint-plugin-nremains for the Node oxlint preset..depcheckrc.jsonignores are updated for the new tooling, andyarn.lockreflects the dependency tree change.Reviewed by Cursor Bugbot for commit 5c914cf. Bugbot is set up for automated code reviews on this repo. Configure here.