Skip to content

fix(stellar-snap): drop Blockaid description for OTHER to use generic security alert - #433

Draft
khanti42 wants to merge 3 commits into
mainfrom
fix/stellar-use-generic-security-copy-for-blockaid
Draft

khanti42 wants to merge 3 commits into
mainfrom
fix/stellar-use-generic-security-copy-for-blockaid

Conversation

@khanti42

@khanti42 khanti42 commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Explanation

Update Stellar wallet snap security alerts to use generic MetaMask copy for malicious transactions, dropping Blockaid descriptions that may contain machine labels when the reason is 'OTHER'. This aligns with the Solana/Tron pattern. Tests and changelog are updated accordingly.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant