Repository navigation
feat(tron): use the shared Asset UI component - #429
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in the focused migration or supporting changes; tests were not executed.
0 open findings
What changed in this PR
Migrates Tron confirmation fee rows to the shared Asset component introduced in #418, continuing confirmation UI consolidation.
Changes:
- Preserves Tron-specific resource icons and fiat formatting.
- Removes the local component and fallback SVG.
- Adds rendering tests and switches Jest to the shared SVG transformer.
| File | Description |
|---|---|
yarn.lock |
Removes Tron’s SVG stub dependency. |
packages/tron-wallet-snap/src/ui/confirmation/components/Fees.tsx |
Uses shared Asset with locally prepared display values. |
packages/tron-wallet-snap/src/ui/confirmation/components/Fees.test.tsx |
Tests fiat, loading, icons, and fee ordering. |
packages/tron-wallet-snap/src/ui/confirmation/components/Asset/Asset.tsx |
Deletes the local component. |
packages/tron-wallet-snap/snap.manifest.json |
Updates the bundle checksum. |
packages/tron-wallet-snap/package.json |
Removes jest-transform-stub. |
packages/tron-wallet-snap/jest.config.js |
Uses the shared SVG transformer and raises coverage thresholds. |
packages/tron-wallet-snap/images/question-mark.svg |
Deletes the redundant fallback icon. |
packages/tron-wallet-snap/CHANGELOG.md |
Documents the shared-component migration. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
|
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Battambang
approved these changes
Oct 9, 2026
Battambang
left a comment
Battambang
left a comment
Contributor
There was a problem hiding this comment.
gj, also by removing the local Asset/Asset.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Tron integration of the shared
Assetcomponent (#418). The confirmation fee rows now render the sharedAsset, replacing the localAssetcomponent, which is deleted along with itsquestion-mark.svg. The bandwidth/energy icon mapping (connect/flash) and fiat formatting stay at the call site.Tron tests now load SVGs with the shared
jest.svg-transformer.jsinstead of the empty stub, which the shared icon requires.References
Checklist