Repository navigation
feat(solana): use the shared Asset UI component - #427
Merged
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused migration preserves fee formatting and loading behavior, with regression coverage and no unresolved findings.
0 open findings
What changed in this PR
Migrates Solana’s confirmation fee row to the shared Asset component introduced in #418, continuing confirmation UI consolidation.
Changes:
- Replaces the custom fee layout while retaining Solana-specific formatting and fiat gating.
- Adds fee-display regression tests and removes the unused
formatCryptohelper. - Updates coverage thresholds, bundle checksum, and changelog.
| File | Description |
|---|---|
packages/solana-wallet-snap/src/features/confirmation/views/ConfirmTransactionRequest/ConfirmTransactionRequest.test.tsx |
Tests fee ordering, loading, and error states. |
packages/solana-wallet-snap/src/features/confirmation/components/TransactionDetails/TransactionDetails.tsx |
Uses shared Asset without an icon. |
packages/solana-wallet-snap/src/core/utils/formatCrypto.ts |
Deletes the unused formatting wrapper. |
packages/solana-wallet-snap/src/core/utils/formatCrypto.test.ts |
Removes tests for the deleted wrapper. |
packages/solana-wallet-snap/snap.manifest.json |
Updates the bundle checksum. |
packages/solana-wallet-snap/jest.config.js |
Adjusts coverage thresholds. |
packages/solana-wallet-snap/CHANGELOG.md |
Documents the fee-row migration. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Solana integration of the shared
Assetcomponent (#418). The confirmation network fee row inTransactionDetails.tsxnow renders a single<Asset>withhideIcon, replacing the hand-built skeleton/fiat/SOL layout. The snap keeps its own fiat gating and formatting;formatCrypto, which had no other callers, is deleted.Fee-row tests were added first and passed against the old implementation, locking in the existing behavior.
References
Checklist