Repository navigation
chore: add unused code checks - #687
memebattle-dev wants to merge 10 commits into
Conversation
3824378 to
c5f84a0
Compare
c5f84a0 to
ea2b5f2
Compare
|
Resolved the lockfile merge conflict in 8bf5558 by syncing master at 2c800da. Preserved Knip 6.32.2, the six-app checking scope and the upstream CAS dependencies. Frozen installation, unused-code checks, formatting, lint, repository tests and independent review passed. Post-build local typechecking reproduces the same three generated Blog route-type errors on the independently installed base. GitHub confirms the pushed branch is mergeable. All completed CI checks now pass, including typechecks and Ligretto E2E; only Storybook awaits protected-environment approval. No application behavior was changed by the conflict resolution. |
|
Resolved the new master conflicts in 3968ebd (master c4ccc47); GitHub confirms the branch is mergeable. The six-app Knip scope is preserved; CAS source and fixtures remain unchanged. Validation: frozen install, lint, formatting and unused-code checks pass. All 312 tests pass with |
|
Investigated the Ligretto E2E cancellation on 3968ebd: GitHub confirms the 10-minute job timeout, and all 12 retained test traces show |
|
CAS health now returns HTTP 200 from the worker. Reran only the previously timed-out Ligretto E2E job: run 36898496345, attempt 2, completed successfully with the PR head unchanged. The remaining Storybook deployment still requires protected-environment approval. |
|
Resolved the new master conflicts in c86080f, preserving the six-app Knip scope and upstream dependencies. Independently reran lint, formatting, unused-code checks and the repository test suite: all pass (389 tests); typechecking retains only the three previously verified Blog generated-validator errors. Independent read-only review found no actionable defects. Local full Ligretto E2E remains blocked by backend prerequisites; the new CI run is the remaining browser verification. |
|
Resolved the new master conflict in 715ae41, preserving the six-app Knip scope and upstream changes. Independently reran lint, formatting, unused-code checks and root pnpm test:ci successfully (389 tests). An earlier serial run timed out in one unchanged CAS Dashboard test; the subsequent root run passed. Typechecking retains the three verified baseline Blog errors. Independent read-only static review found no actionable defects; its execution sandbox was unavailable, so it reviewed the supplied complete diff. CAS sources and fixtures match master. Local Ligretto browser verification remains blocked by Chromium/backend prerequisites; new CI is pending. |
|
Investigated the current Ligretto E2E timeout (run 39301350093): retained browser traces consistently show POST /api/auth/me returning HTTP 500, "Unexpected end of JSON input", before gameplay loads. Retries exhaust the 10-minute job limit. Relevant authentication code, tests and workflow match master; no regression attributable to this PR is evidenced. CAS /health currently returns 200, but that does not verify the legacy POST /auth/temp-token contract consumed by Ligretto; the original upstream response is absent from CI artifacts. The published CAS API no longer advertises that path, which raises a compatibility concern but does not prove the POST response. Blocked pending CAS-owner verification of that legacy endpoint or a compatible CI environment. No speculative source changes, timeout increase or blind rerun made. |
|
Resolved the new master conflict in 0bb882a, preserving the six-app Knip scope and upstream CAS/auth changes. Independently reran lint, formatting and unused-code checks successfully. Root tests recorded 434 passes and one unchanged CAS empty-name assertion failure; the complete affected 30-test suite then passed in a targeted coordinator rerun without edits. Typechecking retains only the three established Blog errors (11 packages pass). Independent read-only static review of the complete final diff found no actionable defects or secrets; its command sandbox was unavailable. No speculative fix for the previously documented Ligretto authentication blocker was included. New CI is pending. |
|
Resolved the new master conflicts in 0f75ca9, preserving upstream auth configuration/test scripts and the approved six-app Knip scope. Added the upstream database test directory to Knip entrypoints; CAS and shared packages match master. Independently reran lint, formatting and unused-code checks successfully. Root tests recorded 570 passes but could not run the core Postgres suite because Docker Compose is unavailable; core unit/functional suites separately pass 32/32. Typechecking retains the three verified baseline Blog errors (11 packages pass). Independent read-only static review of the complete resulting PR diff found no actionable defects or secrets; repository execution was unavailable to that reviewer. Previous-head (0bb882a) Ligretto CI artifacts reproduce the documented legacy auth failure: all 17 retained traces show /api/auth/me returning HTTP 500, Unexpected end of JSON input. No speculative auth changes or CI bypass included. New CI is pending. |
|
Resolved the new master dependency conflicts in d4f08e0, preserving the approved six-app Knip scope and upstream auth migration unchanged. Independently reran lint, formatting and unused-code checks successfully. Root tests record 570 passes but cannot run the core Postgres suite because Docker Compose is unavailable; core unit/functional suites separately pass 43/43. Typechecking retains the three established baseline Blog errors. Independent read-only static review of the complete final PR diff found no actionable defects or secrets; its command sandbox was unavailable. Upstream master now pauses Ligretto E2E pending frontend migration #817; this merge preserves that upstream decision, rather than claiming browser verification. New CI is pending. |
|
Integrated master 5f2d6f8 in ea52c1a, preserving upstream Zod and the approved six-app Knip scope. CAS and shared packages match that base. Independently reran lint, formatting and unused-code checks successfully; core unit/functional tests pass 43/43. Root tests still fail on missing Docker Compose and an unchanged auth timeout assertion (503 versus 200); both matching auth tests pass in an isolated rerun without edits. Typechecking retains the three established Blog errors. Independent read-only static review found no defects; its execution sandbox was unavailable. PostgreSQL store tests and browser E2E remain unverified locally. Master advanced again during verification to d80ced3 (#846), causing another conflict; that follow-up is now in progress in the existing task thread. No new-head CI checks are reported yet. |
|
Integrated master d80ced3 in 1d81847, preserving the approved Knip scope. Coordinator lint, formatting and unused-code checks pass. Root tests failed on unavailable Docker Compose and CAS/Worker tests; isolated coordinator reruns pass 51/51 and 4/4 without changes. Typechecking retains the three established Blog errors. Independent static full-diff review found no defects or secrets; sandbox execution was unavailable. The newer master has already introduced another merge conflict, so this is not merge-ready and no current-head CI checks are reported. |
Summary
unused_code:check/unused_code:removecommands and a dedicated unused-code CI jobmasterat2c800dain merge commit8bf5558, resolving the root lockfile conflict while preserving Knip 6.32.2, the base toolchain and new CAS frontend dependenciesValidation
pnpm unused_code:checkfail andunused_code:removeremoves it; no synthetic artifacts retainedpnpm install --frozen-lockfile,pnpm unused_code:check,pnpm fmt:check,pnpm lint:check,pnpm test:ci, andgit diff --checkpasspnpm ts-checkpasses before the Blog build; after the build it reports three TS2344 locale constraint errors in generated.next/types/validator.ts(lines 81, 94, 103). An independently installed base at2c800dareproduces identical diagnostics8bf5558a14bf34403f4269b47f5c854717fbb244is mergeable; all completed CI checks pass, including unused-code, typechecks, unit tests, images and Ligretto E2E. Only Storybook remains waiting for protected-environment approvalRisks
unused_code:removeuses Knip fix mode with file removal enabled; generated diffs must be reviewed before retentionFixes #632