Repository navigation
ci: check the system parameter catalog in cargo test - #40348
Merged
antiguru merged 1 commit intoOct 29, 2026
Merged
Conversation
Running bin/gen-system-parameter-catalog from check-generation.sh compiles mz-sql and every dyncfg crate in the "Lint and rustfmt" job. Compare the checked-in catalog in a unit test instead, where the cargo-test job already builds these crates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
def-
approved these changes
Oct 29, 2026
def-
left a comment
def-
left a comment
Contributor
There was a problem hiding this comment.
Thanks, seems good enough to me!
antiguru
enabled auto-merge (squash)
October 29, 2026 12:00
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
bin/gen-system-parameter-catalogfromcheck-generation.sh(#40217) compilesmz-sqland every dyncfg crate, about 1050 crates, inside the "Lint and rustfmt" job. Extracting the definitions into light crates does not help much: theSystemVarsdefinitions depend onmz-repr, which alone pulls in 435 crates, and the dyncfgs are spread across about 25 modules in 7 crates.This moves the staleness check into a unit test in
mz-system-parameter-catalogthat compares the checked-insrc/sql/system-parameters.jsonagainst the generated catalog. The cargo-test job already builds these crates. Regeneration staysbin/gen-system-parameter-catalog, and the mz-commit and mz-feature-flags skills now mention it.🤖 Generated with Claude Code