Repository navigation
skills: add mz-console-review for reviewing Console PRs - #39880
Merged
Merged
Conversation
mz-pr-review's checklists are Rust-specific, so Console PRs had no review skill. mz-console-review encodes what Console reviewers flag in practice, distilled from roughly 570 review comments on about 150 Console PRs and ordered by frequency: removal and simplification, SQL and catalog correctness, reuse of existing helpers, tests, types, naming, loading and error states, data layer, routing, versions and flags, visual QA, and charts. It also covers running the change to verify claims before writing them, catalog_server cost and render-performance probes (in cost-and-structure.md), comment voice, and posting findings as a single GitHub review. Every cited path and symbol was checked against main. mz-pr-review's description now points Console changes at the new skill, and the skills README gains a Console section listing it alongside mz-query-perf.
console/AGENTS.md told agents to use useSqlLazy for imperative calls and listed the useSql* hooks as the data-fetching API. New code uses react-query useQuery and useMutation instead, so the doc now describes that pattern with examples from platform/clusters/queries.ts and marks the useSql* hooks as legacy. mz-console-review points at that section instead of restating it.
leedqin
requested review from
Alphadelta14,
SangJunBak,
bosconi and
jdonelson
and removed request for
Alphadelta14
October 15, 2026 20:58
jdonelson
approved these changes
Oct 16, 2026
Co-authored-by: Jeremy Donelson <jeremy.donelson@gmail.com>
leedqin
enabled auto-merge (squash)
October 16, 2026 17:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mz-pr-review's checklists are Rust-specific, so agents reviewing a Console (console/) PR had nothing that encodes how Console code is actually reviewed. They fall back to generic React advice and miss the repo's own helpers, catalog quirks, and conventions.Description
Adds
.agents/skills/mz-console-review, a review skill for diffs underconsole/:cost-and-structure.md: deeper checks a read of the diff misses, loaded only when the diff touches a query, poll, subscribe, hot interaction, or hooks. Coversmz_catalog_servercost (EXPLAIN with the Console's session settings, index use, per-viewer subscribe and poll cost) and render-count probes. Kept separate soSKILL.mdstays under the 500-line skill guideline.Smaller changes:
mz-pr-review's description points Console changes at the new skill, since both otherwise match "review my PR".mz-query-perf, which had no README entry.console/AGENTS.md(whichconsole/CLAUDE.mdlinks to) told agents to useuseSqlLazyfor imperative calls and listed theuseSql*hooks as the data-fetching API. New code uses react-queryuseQuery/useMutation, so its "useSql Hooks" section is now "React Query", with the read and write pattern and examples fromplatform/clusters/queries.ts, and theuseSql*hooks are marked legacy. The skill points at that section instead of restating it.Verification
Every file path and exported symbol the skill cites was checked against
main. Helpers that exist but are module-private are flagged as "export it" rather than "reuse it". The checkout and cleanup commands in section 1 were run against a scratch repo with both added and modified files. The whitespace, copyright, and Slack-link lints pass.🤖 Generated with Claude Code