You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds a Files screen to the Demo app (Misc → Files) that exercises every method of the openAI.files namespace added in #401:
List: files with a purpose filter, pull-to-refresh, "Load More" paging, swipe to delete, and an empty state (files.list(query:)).
Upload: a sheet that picks any file, a purpose (the six upload purposes), and an optional expiration of 1–720 hours (files.create(query:), with expiresAfter).
Detail: all file fields, Refresh (files.retrieve(id:)), Download Content with a text preview and Share (files.content(id:)), and Delete with confirmation (files.delete(id:)).
Other providers see the existing "OpenAI-only" placeholder. API errors are shown in an alert.
FilesStore depends only on FilesEndpointProtocol, the way ResponsesStore depends on the Responses endpoint, so its tests use a fake endpoint: filter and page size, loading the next page, upload fields including expiration, delete, and error handling (6 tests).
Screenshots
List
Upload
Detail
Purpose filter
Empty state
Why
The Demo is currently the only way to exercise the package end to end against the live API: the test suite uses mocked sessions and CI doesn't build the Demo. This is the first step of #468, which tracks covering every public API in the Demo.
Testing
Run in the iOS Simulator against the live API while #401 was in review. It found two bugs in #401, which were fixed there before it merged:
Empty pages failed to decode. The API returns null for first_id and last_id on an empty page. Filtering by a purpose with no files now shows the empty state.
files.content(id:) returned API errors as content. Downloading a file whose purpose doesn't allow downloads now shows "Not allowed to download files of purpose: user_data".
Also checked live: uploads with user_data (with a 1-hour expiry) and evals (the API returns "purpose": "evals", which the edited OpenAIFile decodes), retrieve, content download, and delete. Test files were deleted afterwards.
DemoChat tests pass (41), and the Demo app builds for the iOS Simulator.
Misc > Files lists the organization's files with a purpose filter,
pull-to-refresh and paging, uploads a file with a chosen purpose and an
optional expiration, and opens a file to refresh its details, show and
share its content, or delete it. It exercises every method of
openAI.files end to end. Other providers see the OpenAI-only placeholder.
FilesStore takes only FilesEndpointProtocol, like ResponsesStore takes
the responses endpoint, so its tests use a fake endpoint.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
After a failed reload, for example under a new purpose filter, the list
kept showing files that may not match the filter.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The detail screen wrote the downloaded content to the temporary directory
under the file's API-provided name before sharing it. A name such as
../x resolved outside that directory, files with the same name overwrote
each other's copy, and a failed write was silently ignored.
Share the in-memory data through a Transferable instead, suggesting only
the name's last path component, or the file ID when nothing usable is
left.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reloads and Load More could overlap: changing the purpose filter, pulling
to refresh or loading more while another request was in flight let a
slower response overwrite a newer one, and the first request to finish
cleared isLoading while the other was still running.
Skip a load while another one is running, and disable the purpose filter
while loading so that a filter change is never skipped.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
FilesStore is main-actor isolated and read the picked file synchronously
before the upload's first suspension point, so a large file (uploads can
be up to 512 MB) froze the UI until it was read. Read it in a detached
task, keeping security-scoped access for the duration of the read.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The detail screen decoded the whole download as a String and counted its
characters on every re-render, before cutting it to 5,000 characters. For
a large file, such as batch output, that is a second full-size copy and a
full traversal on the main thread each time the view updates.
Build the preview once when the download finishes, from at most the first
20,000 bytes, and decide truncation from the byte count. A cut that splits
a multi-byte UTF-8 character drops up to 3 trailing bytes instead of
misreporting the content as binary.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Load More stops paginating after all loaded files are deleted
Demo/DemoChat/Sources/FilesStore.swift:46
Deleting every loaded file while hasMore is true leaves files.last nil. Load More then returns without requesting the remaining files, and the screen incorrectly shows an empty state. Allow Load More to request the first remaining page when the local list is empty.
Stale list responses overwrite concurrent uploads and deletions
Demo/DemoChat/Sources/FilesStore.swift:59
The loading guard serializes list requests, but uploads and deletions can still change files while a list request is suspended. For example, swipe deletion can succeed before an older reload response arrives; this assignment then restores the deleted row, whose subsequent requests fail. A reload can likewise overwrite a newly inserted upload. Coordinate mutations with list publication by reconciling overlapping changes or invalidating stale responses and refetching.
A list response could undo a change made while it was in flight: a
deletion during a reload brought the deleted row back, an upload during a
reload disappeared from the list, and a reload started during a deletion
could return the file before the server removed it. FilesStore now runs
one request that changes the list at a time, refusing uploads and
deletions while loading and skipping loads while one is in flight; the
UI disables the controls that start them meanwhile.
Load More gave up once every loaded file had been deleted, because it
used the last loaded file as the cursor. It still does, as the API
rejects a deleted file as the cursor (404), but it now loads the first
page when no loaded file remains.
The tests' fake endpoint is now main-actor isolated like the tests, so
recording a request and holding it can't interleave with a test's checks,
which could leave a test waiting forever.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lists, uploads and deletions all only need to know whether any request
is in flight, so replace isLoading and isChanging with one stored flag.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixes for the two findings Copilot listed under "Previously missed", which have no review threads of their own:
Load More stops paginating after all loaded files are deleted: fixed in 50a722a. The cursor is still the last loaded file that remains in the list, because the API rejects a deleted file as after with a 404 (checked against the live API). When every loaded file has been deleted, Load More now fetches the first page instead of doing nothing.
Stale list responses overwrite concurrent uploads and deletions: fixed in 50a722a and 508c150. FilesStore now runs one request that changes the list at a time (list, upload or delete), tracked by a single isBusy flag: uploads and deletions are refused while a list request is in flight, and list requests are skipped while an upload or deletion is. The UI disables the controls that start them while busy: the purpose filter, +, swipe to delete, Load More, and Delete on the detail screen.
Both have tests, and the new tests fail when the fixes are reverted.
This empty-state overlay covers the entire list, including the purpose picker. When a filter returns no files, it can intercept taps needed to select another filter; it also sits over Load More when all loaded files have been deleted but more pages remain. Make this decorative overlay non-hit-testable so the underlying controls remain usable.
After a failing test, xcodebuild runs simctl diagnose on the simulator
and waits for it, which looks like a hang and turned quick checks into
multi-minute waits.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
FilesView created its own FilesStore from the client it was given, so it
kept that client after a configuration change. APIProvidedView now owns the
store like the other stores and sets its client in rewireClient(). Setting
the client clears the loaded list and ignores responses for the previous
client, since the new one may use another account.
The FilesStore suite gets a time limit: tests that hold requests in flight
deadlock on a mistake, and should fail instead of waiting forever.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cancel only dismissed the sheet, and the file was still read and sent to
OpenAI. Dismissing the sheet, with Cancel or by swiping it down, now cancels
the upload task. The store checks for cancellation after reading the file,
so nothing is sent if it came during the read, and the client cancels the
request otherwise. A cancelled upload isn't shown as an error.
One test cancels before sending and checks that nothing is sent. Another
goes through a real client and URLSession, with a URLProtocol that never
answers, and checks that the request is stopped.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ignore cancellation errors when leaving the Files screen
Demo/DemoChat/Sources/FilesStore.swift:80
Leaving the Files screen cancels its initial .task reload. If the request is still running, URLSession throws a cancellation error, which this catch publishes as a request failure. That can leave a spurious alert for the next visit. Ignore cancellation here, as the upload path already does.
upload() reads the file before calling the client, so a configuration
change during the read would send the file to the new client, possibly
another account. The response would be ignored, but the file would
already be there. Check that the client hasn't changed before sending.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deleting every loaded file leaves hasMore true when additional pages remain. This condition then shows “No Files” and prompts an upload even though more files can be loaded. The store already supports this case in loadMoreLoadsTheFirstPageWhenEveryLoadedFileWasDeleted. Show the empty state only when pagination is exhausted.
The test switched the client once the store was busy, relying on the main
actor running the test before the read finished. Swift doesn't promise
that order. FilesStore now takes the file reader as a parameter, and the
test passes one that holds the read until the client has been switched.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Normal navigation cancellation is published as a request failure that persists after a successful reload.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Ignore request cancellation to prevent spurious error alerts
Demo/DemoChat/Sources/FilesStore.swift:88
Leaving Files while its initial .task is loading cancels the request. This catch publishes that normal cancellation as “Request Failed” in the app-owned store, and a subsequent successful reload does not clear it. Ignore cancellation using the existing isCancellation helper, as upload already does, so normal navigation does not leave a spurious error alert.
Leaving the Files screen while its first load is running cancels the
load, and URLSession throws URLError.cancelled. The store published that
as a failure, and since the store now outlives the screen, the next visit
opened with a "Request Failed" alert. Ignore cancellation in list
requests, as uploads already do.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
After deleting every loaded file while more pages remain, the screen said
"No Files" next to the Load More button. The empty state now also
requires that there's nothing more to load, and no longer takes taps, so
it can't cover the purpose picker.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Files screen to the Demo app (Misc → Files) that exercises every method of the
openAI.filesnamespace added in #401:files.list(query:)).files.create(query:), withexpiresAfter).files.retrieve(id:)), Download Content with a text preview and Share (files.content(id:)), and Delete with confirmation (files.delete(id:)).Other providers see the existing "OpenAI-only" placeholder. API errors are shown in an alert.
FilesStoredepends only onFilesEndpointProtocol, the wayResponsesStoredepends on the Responses endpoint, so its tests use a fake endpoint: filter and page size, loading the next page, upload fields including expiration, delete, and error handling (6 tests).Screenshots
Why
The Demo is currently the only way to exercise the package end to end against the live API: the test suite uses mocked sessions and CI doesn't build the Demo. This is the first step of #468, which tracks covering every public API in the Demo.
Testing
Run in the iOS Simulator against the live API while #401 was in review. It found two bugs in #401, which were fixed there before it merged:
nullforfirst_idandlast_idon an empty page. Filtering by a purpose with no files now shows the empty state.files.content(id:)returned API errors as content. Downloading a file whose purpose doesn't allow downloads now shows "Not allowed to download files of purpose: user_data".Also checked live: uploads with
user_data(with a 1-hour expiry) andevals(the API returns"purpose": "evals", which the editedOpenAIFiledecodes), retrieve, content download, and delete. Test files were deleted afterwards.DemoChattests pass (41), and the Demo app builds for the iOS Simulator.Affected Areas
Demo/DemoChat/Sources/FilesStore.swift,Demo/DemoChat/Sources/UI/Files/(new)Demo/DemoChat/Sources/UI/Misc/MiscView.swift: Files linkDemo/DemoChat/Tests/FilesStoreTests.swift(new)No changes to the package.
🤖 Generated with Claude Code