Fix #1091: Prevent legacy Principled BSDF from rendering as mesh lights - #1093
Merged
Merged
Conversation
… as mesh lights Legacy Principled BSDF materials from older Blender versions were incorrectly exported with emission=1, causing them to render as mesh lights instead of regular materials. Root cause: - Unconditionally read "Emission Strength" socket (default value 1.0) - No check if emission was actually used/linked - Blender 3.6 uses "Emission", Blender 4.0+ uses "Emission Color" Solution: - Detect socket name (Emission vs Emission Color) for version compatibility - Check if emission color/strength is linked OR has non-zero values - Only export emission property when genuinely needed - Combine color * strength using scale texture Impact: - Linked assets from older Blender versions now render correctly - No false mesh light conversions - Backward compatible with all Blender versions Fixes LuxCoreRender#1091 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy Principled BSDF materials from older Blender versions were incorrectly exported with emission=1, causing them to render as mesh lights instead of regular materials.
Root cause:
Solution:
Impact:
Fixes #1091