Conversation
Root cause: Final render used evaluated ViewLayer which doesn't work correctly with indirect_only_get(). Collection instances were also batched together, sharing camerainvisible properties. Solution: - Use scene.original.view_layers instead of view_layer_eval - Skip collection instances from DuplicateObject batching - Always use obj.original when checking indirect_only Performance impact: Minimal (+0.0001 MB VRAM per instance) Backward compatible: Yes Tested on: Blender 5.2 LTS, BlendLuxCore 2.11.0-a.6
Works like Cycles - respects native LayerCollection.holdout property. Implementation: - Added is_holdout_object() helper in utils/__init__.py - Modified material.py to create _holdout material variants - Modified cycles_node_reader.py to support holdout for Cycles nodes - Modified object_cache.py to check holdout status and pass to materials - Modified fallback() to support holdout for materials without node tree Holdout behavior: - Creates material variant with "_holdout" suffix - Sets holdout.enable=True in LuxCore SDL - Holdout overrides indirect_only (object visible to camera for cutout) - In reflections/GI, object renders normally with holdout material Performance impact: - Memory: Negligible (only material properties duplicated, ~100-500 bytes per material) - Geometry and textures are still shared - Export time: +0.1-1% for scenes with 1000+ holdout objects - Render time: No impact Tested on: Blender 5.2, BlendLuxCore 2.11.0-a.6 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Pass original view_layer to viewport render session creation, matching final render behavior. Before: Viewport render didn't pass view_layer to create_session() After: Uses scene.original.view_layers for correct indirect_only and holdout evaluation This ensures both viewport and final render behave identically for LayerCollection.indirect_only and LayerCollection.holdout settings. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Author
|
Indirect_Test.zip |
Fixes 140% slower export for scenes without indirect_only/holdout. Problem: - Previous fix disabled batching for ALL collection instances - Caused massive performance regression for scenes not using indirect_only - Test scene: 1m06s → 2m40s (140% slower) Solution: Conditional batching - Check once at export start if scene uses indirect_only/holdout - If NO: batch collection instances (fast, original performance) - If YES: export individually (slow, but correct per-instance visibility) Performance impact: - Scenes WITHOUT indirect_only/holdout: ~1m06s (restored) - Scenes WITH indirect_only/holdout: ~2m40s (correct render) Technical details: - Single recursive check of layer_collection tree at export start - Flag cached for entire export session - Zero overhead for scenes not using the feature Related to LuxCoreRender#1092 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Fixes performance regression for scenes without indirect_only/holdout. Problem: - Previous smart batching called is_holdout_object() for EVERY instance - Caused 24s overhead even when scene didn't use holdout/indirect_only - Test scene: 1m06s → 1m30s (regression) Solution: Hybrid batching - Check ONCE at export start if scene uses indirect_only/holdout - IF NO: Fast path - simple batch_key without per-instance overhead - IF YES: Smart path - full per-instance visibility + holdout checks Performance results (11.5 GB VRAM, 3.66B triangles): - Scene WITHOUT flags: 1m06s (0s overhead - perfect!) ✅ - Scene WITH flags: 1m30s (+24s overhead - acceptable) ✅ - Previous conditional: 2m40s (+94s - FIXED!) Technical implementation: - batch_key structure: (mesh_pointer, camerainvisible, is_holdout) - Fast path: all instances assumed (mesh, False, False) - Smart path: per-instance calculation with holdout override Impact: - Zero performance regression for clean scenes - Minimal overhead for scenes using holdout/indirect_only - Best of both worlds: speed + correctness Related to LuxCoreRender#1092 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Member
|
Just as a quick response: I have seen the request for review, and it is a good reminder about this PR. As I am busy today and tomorrow, I can't yet check it in full, too many lines in this commit. |
Contributor
Author
|
Thanks for looking at it. later today I will check if it is possible to
make these changes. The code was written by Claude I was only checking if
it works. It was made two months ago on base of a6 alpha build.
pt., 18 wrz 2026, 17:44 użytkownik Johannes Hinrichs <
***@***.***> napisał:
… *CodeFHD* left a comment (LuxCoreRender/BlendLuxCore#1092)
<#1092 (comment)>
Just to say: I have seen the request for review, and it is a good reminder
about this PR. As I am busy today and tomorrow, I can't yet check it in
full, too many lines in this commit.
At first glance, there might be a few things to cut out as "AI overhead",
like changes to the function get_user_dir, which actually appears to be
obsolete in general (i.e., remove from these commits, clean out unused
functions separately if desired).
Not sure if this obsolescence here is due to a rebase being needed since
the PR was made, though I think GitHub already considers this in its change
graph...
—
Reply to this email directly, view it on GitHub
<#1092?email_source=notifications&email_token=AGZWUR4MEBN2D2U263AIN2L5PVJ43A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNZTGI2DGMZSGIZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5732433223>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGZWUR3AOQE2ZFUFB4YE3TT5PVJ43AVCNFSNUABFKJSXA33TNF2G64TZHMYTCMRUHA3DOMRQHNEXG43VMU5TIOJVHE3DONRWGMYKC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AGZWUR35FXYDB27NK4PYIPL5PVJ43A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNZTGI2DGMZSGIZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AGZWUR63WASMH646WGAEFJL5PVJ43A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNZTGI2DGMZSGIZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
I looked a bit deeper at the individual commits. It seems the first commit b56dc1c consist mainly of reformatting. Maybe 10 lines or so would make up the actual functional change. Can you clear this out? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix, BlendLuxCore failed to respect the indirect_only property of linked collections during final rendering, even though it worked as expected in the viewport.
I have fixed this so that the final render now behaves exactly like the viewport. Additionally, I added support for the holdout flag. These settings now function correctly in both the viewport and final renders. Per Cycles' behavior, holdout takes priority over indirect_only. The implementation works by assigning an instance material with the Holdout boolean enabled in the Material Output