Repository navigation
feat: default API host to platform.lightning.ai - #210
Closed
vivequeramji wants to merge 2 commits into
Closed
vivequeramji wants to merge 2 commits into
vivequeramji wants to merge 2 commits into
Conversation
The API is moving from lightning.ai/v1 to platform.lightning.ai/v1. Point the Python, JS and Go defaults at the new host, and have the SSH key downloads follow LIGHTNING_CLOUD_URL instead of hard-coding lightning.ai. Part of gridai/16102026-recovery#309.
vivequeramji
requested review from
ethanwharris,
justusschock and
owbone
as code owners
October 26, 2026 12:39
vivequeramji
added
the
vendoring
vivequeramji
requested review from
Danidapena,
k223kim,
rusenask,
tchaton and
tejapulagam
as code owners
October 26, 2026 12:39
Contributor
Author
|
Superseded by #211, same commits on a branch named |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default the SDK's API host to
https://platform.lightning.ai, as the API moves fromlightning.ai/v1toplatform.lightning.ai/v1.Tracking issue: gridai/16102026-recovery#309 (part of gridai/16102026-recovery#3)
Companion: gridai/grid#48815, the upstream defaults this mirrors.
Changes
api/utils.pyand the vendoredlightning_cloud/env.py), JS (config.ts) and Go (sdkclient) default base URL._get_cloud_url()instead of their ownlightning.aifallback.LLM"is prod" check matches onlyhttps://platform.lightning.ai.ssh-genandssh-publicdownloads followLIGHTNING_CLOUD_URL. They were hard-coded tolightning.ai, and they are control-plane routes thelightning.aiworker does not pass through.Notes
lightning_sdk/lightning_cloud/env.py, the same one-line change as grid'slightning-cloud/python/lightning_cloud/env.py), so it carries thevendoringlabel. Grid's vendoring workflow is currently parked inworkflows-disabled.platform.lightning.aiis assumed live and publicly resolving; no legacy-host compatibility is kept.cli-testsanddocs-linkcheck (cli)fail only on DNS until it is.python/tests/core/test_teamspace.pysetLIGHTNING_CLOUD_URLinpatch.dict, butdataset.pyreads the import-timeenvconstant, so those tests only passed because the default matched. They now expect the new default.Verification
tests/cli/job/test_list.py, table width truncation) fail identically onmain.go test ./...passes. JS: 80/80 pass.