Repository navigation
feat: support fetching images in private books - #111
Merged
Merged
Conversation
jakeaturner
requested review from
ethanaturner
and
a balanced review from Copilot
October 5, 2026 19:41
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
LocalStack provisioning uses undocumented and unvalidated Engineering credentials, causing misleading failures with the documented configuration.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds authenticated CXOne asset fetching so private-book images work in PDF and EPUB exports.
Changes:
- Adds anonymous-first fetching with authenticated retry.
- Integrates fetching into PDF and EPUB image processing.
- Adds Engineering library credentials to LocalStack provisioning.
| File | Description |
|---|---|
src/lib/cxOneAssetFetcher.ts |
Implements secure asset fetching and redirects. |
src/services/library.ts |
Exposes fresh CXOne authentication headers. |
src/services/imageProcessor.ts |
Localizes restricted PDF images. |
src/services/epub.ts |
Uses authenticated fetching for EPUB images. |
create-localstack-resources.sh |
Provisions Engineering credentials. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ethanaturner
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.