Repository navigation
Conversation
…Modal Changed the tooltip placement from "bottom" to "left" in both RecoveryModal and StartOverModal components for improved UI consistency.
Eliminated unnecessary state updates for selectedBookNodeId in the delete and restore functions to streamline the RemixerDashboard component's behavior.
Added a tooltip to the restore button for deleted items, providing users with context on its function. Updated the button's styling for better visibility and user experience.
…blic domain pages Revised comments and test descriptions to reflect the change in terminology, ensuring consistency across the Restacker component and related tests. This includes updates to the logic for identifying pages that must be public domain.
Revised the terminology for "Multiple Licenses" to "Multiple Licenses(Collection)" in the LicenseOptions component and its tests. Adjusted column sizes in the Restacker component for improved layout consistency. Updated the BulkLicenseModal to reflect the change from "structural" to "core" for public domain pages.
Added tests and logic to ensure the CK-12 license is only compatible with itself. Updated the license compatibility functions in both the client and server to reflect this new behavior, enhancing compliance validation.
… confirmation modals Updated the GlossaryList component to include confirmation modals for deleting glossary terms and removing pages from glossary terms. This change improves user experience by preventing accidental deletions and providing clear feedback on actions taken. Additionally, refactored the onClick handlers for better readability and maintainability.
…mponents Introduced a new accessibility test suite for the LicenseTable and LicenseEditor components, ensuring proper row header functionality and button labeling for screen readers. Updated the LicenseTable to use semantic HTML elements for better accessibility and improved the LicenseEditor with clearer aria-labels. Additionally, refactored the BulkLicenseModal and ComplianceDetails components to enhance their accessibility features.
… components Updated the ConsultInsightButton to improve accessibility by consolidating the button and link into a single element with appropriate aria-labels. Refactored the LicenseTable to utilize RowHeaderDataTable for better semantic structure and accessibility. Introduced a new utility component, RowHeaderDataTable, to support row headers in data tables. Enhanced the CatalogList component to include row headers and improved the overall user experience with clearer labeling and selection handling.
…stinction Enhanced the BookActions component by introducing a 'wide' property for editing actions, allowing them to render with increased width for better visual separation from view controls. Updated the class names accordingly to reflect this change. Additionally, modified the GlossaryDefinitionPreview to handle MathJax loading errors silently, ensuring raw TeX remains readable if typesetting fails. Cleaned up debug logs in the mathjax utility functions for a cleaner codebase.
… related components Introduced a new `sourceVersion` field to the glossary entry model, allowing for the specification of license versions. Updated the API and various components, including forms and CSV export functionality, to handle this new field. Enhanced the BulkAttributionDialog and GlossaryForm to include license version selection, improving user experience and data accuracy. Adjusted related tests to ensure proper functionality with the new field.
…ion format Modified test cases in BulkAttributionDialog and services to change the expected `sourceVersion` from "4.0" to "40", ensuring consistency with recent updates to the glossary entry model. This change enhances the accuracy of the tests following the introduction of the new license version format.
|
Severity: Medium — manager.tsx:136: The API accepts dotted versions such as Severity: Low — services.ts:185: CSV exports write internal version keys ( |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.