Skip to content

🗂️ feat: Route Bash PTC Through Selected Workspaces - #540

Merged
danny-avila merged 5 commits into
mainfrom
danny-avila/byom-ptc-skills
Sep 14, 2026
Merged

danny-avila merged 5 commits into
mainfrom
danny-avila/byom-ptc-skills

Conversation

@danny-avila

@danny-avila danny-avila commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • pass the selected BYOM workspace ID through Bash programmatic execution and every replay continuation
  • route injected skill files through the selected-workspace PTC path while preserving the direct workspace fast path for ordinary commands
  • use the worker-advertised portable code-data directory rather than assuming /mnt/data
  • distinguish ephemeral execution artifacts from durable project files in model-facing summaries
  • preserve auth, timeout bounds, and protected workspace selection headers on every request
  • give each abortable PTC request an opaque ID and send an authenticated, bounded explicit cancellation request so Stop does not depend on HTTP socket teardown

Compatibility

  • no workspace behavior changes unless LibreChat supplies a selected workspace ID
  • explicit cancellation is best-effort against older Code API versions; the original abort and server deadline remain backward-compatible fallbacks
  • the Code API capability gate determines whether selected-workspace Bash PTC is offered

Focused verification

  • npx eslint on the changed source/test files
  • npm test -- --runInBand src/tools/__tests__/CodeApiAuthHeaders.test.ts (79 passing)
  • npm run build
  • isolated live E2E through Code API and a real native SRT worker, including multi-iteration tool replay, skill injection, and explicit cancellation that immediately releases the running process/worker slot

@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head 332b15e. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T09:58:47.208078Z 73475ae Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 332b15e271

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/tools/BashExecutor.ts
Comment thread src/tools/BashExecutor.ts
Comment thread src/tools/BashProgrammaticToolCalling.ts
Comment thread src/tools/BashExecutor.ts
Comment thread src/tools/BashProgrammaticToolCalling.ts Outdated
Comment thread src/tools/CodeSessionFileSummary.ts
Comment thread src/types/tools.ts Outdated
@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head 05e3c94. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 05e3c94e8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila

Copy link
Copy Markdown
Collaborator Author

Correction: please review exact head be80f51.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be80f51f5f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/tools/BashExecutor.ts Outdated
Comment thread src/tools/BashExecutor.ts
Comment thread src/tools/BashExecutor.ts Outdated
Comment thread src/tools/BashExecutor.ts
@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review exact head 1c41ee7

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 1c41ee79da

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review exact head 73475ae. The prior findings are fixed, focused tests/builds pass, and the second-order issue classes were self-reviewed.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 73475ae755

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila danny-avila mentioned this pull request Sep 14, 2026
@danny-avila
danny-avila added this pull request to stack #544 September 14, 2026 13:21
@danny-avila danny-avila changed the title 🧭 feat: Route Bash PTC Through Selected Workspaces 🗂️ feat: Route Bash PTC Through Selected Workspaces Sep 14, 2026
@danny-avila
danny-avila merged commit 0977f23 into main Sep 14, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant