chore: adding more tests to pass cargo mutants - #60
Merged
Merged
Conversation
sanbox-irl
force-pushed
the
chore/mutant-tests
branch
from
September 13, 2026 22:29
fa2407b to
6c4064f
Compare
LPGhatguy
reviewed
Sep 15, 2026
| } | ||
|
|
||
| #[test] | ||
| fn aba_test() { |
Owner
There was a problem hiding this comment.
I legitimately internalized this as the ABBA problem and so every time you said "ABA" IRL I was like "isn't it ABBA?"
Contributor
Author
There was a problem hiding this comment.
the ABBA problem is when you have too many men after midnight
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now pass the following command:
There are two mutants which we ignore:
Index::to_bits's|operator with^-- this substitution is simply correct and ideally is actually done by the compiler itself (and in fact, is), so it's not a problem or a bug.It is possible to add cargo mutants as a dependency and add ignoring these in code, but I don't think that's ever worth it to add clutter.
Generally, we were hitting 210 out of 220 mutants immediately. I simply added a few more small tests, all of which we passed immediately, so this is just for correctness -- I discovered no new bugs.