Skip to content

[MPM] Compute reactions flag#1015

Merged
lauramoremar merged 4 commits into
masterfrom
mpm/compute-reactions-flag
May 13, 2026
Merged

[MPM] Compute reactions flag#1015
lauramoremar merged 4 commits into
masterfrom
mpm/compute-reactions-flag

Conversation

@jginternational
Copy link
Copy Markdown
Member

Hi @ncrescenzio

Please change this draft into a PR when you feel that this changes can fit into MPM applications in production

@lauramoremar lauramoremar marked this pull request as ready for review May 11, 2026 15:42
@lauramoremar
Copy link
Copy Markdown
Contributor

Hi! I think we should include this option in the interface, since it is useful when reactions are requested for plotting in the postprocess or for computing forces into a file. My only doubt is whether this is the correct section Strategy parameters in the interface, or if it should instead belong to the postprocess section, Results (although, at the same time, it is also something that needs to be computed...).

image

What do you think? @ncrescenzio @andimkatili @antonialarese

@lauramoremar lauramoremar self-assigned this May 11, 2026
@lauramoremar lauramoremar self-requested a review May 11, 2026 15:53
@lauramoremar lauramoremar changed the title MPM compute reactions flag [MPM] Compute reactions flag May 11, 2026
@ncrescenzio
Copy link
Copy Markdown
Contributor

@lauramoremar I would leave it here because it is more consistent with the structure of the json parameters. Moreover this option is also used to initialize the MPMResidualBasedNewtonRaphsonStrategy, so I think it makes sense to leave it here

Copilot AI review requested due to automatic review settings May 13, 2026 06:58
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@lauramoremar lauramoremar merged commit 934b34a into master May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants