version diff - #4
Open
Kenneth-T-Moore wants to merge 5141 commits into
Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Convert Aircraft.Engine.REFERENCE_SLS_THRUST to a variable
…E_POSITION_FACTOR so it is a single value
… instead of Aircraft.Engine.NUM_WING_ENGINES (which is a vector)
… into GASP_smooth_not_smooth
Unify PreMissionGroup and PostMissionGroup into a single group.
The prepare_environment composite action does its own unqualified actions/checkout@v6 with no path: argument, which wipes the workspace root -- including any ./src/ we've laid down. This caused workflow_dispatch runs on release tags to fail at the Build docs step with: Error: An error occurred trying to start process '/usr/bin/bash' with working directory '/home/runner/work/Aviary/Aviary/src'. No such file or directory Reorder so prepare_docs_environment runs first (its internal checkout lands in the workspace root and we ignore that tree) and the tag checkout into ./src/ runs afterward. ./actions/ survives both because actions/checkout only cleans the directory it owns. Co-Authored-By: Claude <noreply@anthropic.com>
Both tests in test_bench_solved2dof.py drive the problem with IPOPT, which requires pyOptSparse, but the file never imported or applied @require_pyoptsparse. Without pyOptSparse installed they raise "ImportError: pyOptSparseDriver is not available" and fail, rather than skipping the way every other pyOptSparse-dependent benchmark does. This is the only benchmark file that uses a pyOptSparse optimizer without the decorator; the 20 others already guard their IPOPT/SNOPT tests this way.
…ing_CI improved the scaling for the solved 2dof landing benchmark to make it more stable.
…optsparse-skip skip solved2dof benchmarks when pyOptSparse is unavailable
…posite-checkout-order Fix publish_docs.yml: composite action was wiping ./src/
MAX_MACH update
Provide a better report to help identify overrides that prevent design variables from correctly impacting the problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary of PR.
Related Issues
Backwards incompatibilities
None
New Dependencies
None