Repository navigation
Generalize Quarkus module warning allowlists across apps - #460
Conversation
How can this be caused by the referenced quarkus issue? It's not merged. |
|
Do we know which change introduced this? And if so why we move this out of the 4.x conditional? Is this in older quarkus releases too now? |
|
I think this is meant to fix #463 which is quarkus main only so far in our CI. |
It's an issue that doesn't have a merge fixed yet.
The new warning is issued after the changes in quarkusio/quarkus#53378 which fallsback to https://github.com/quarkusio/quarkus/blob/d3acb50e1af5a8beafd2a6deb6743c9af82ef918/independent-projects/bootstrap/app-model/src/main/java/io/quarkus/maven/dependency/ResolvedDependency.java#L200 when the app has no explicit module name. quarkusio/quarkus#57400 increased the number of this kind of warnings
The intention was to move them to all benchmarks. The 4.x conditional can be retained. Good catch.
AFAIK no. I will adapt the patch accordingly. Thanks for the review. |
Reduces CI noise caused by quarkusio/quarkus#57727
e429348 to
a88bdcf
Compare
|
@zakkak Could you please update the description. It doesn't seem accurate (or at least confuses me). Thanks! |
|
Done |
New warnings are shown when using Quarkus 4 after the changes in quarkusio/quarkus#53378 (Specifically https://github.com/quarkusio/quarkus/pull/53378/changes#diff-7d1388bbdd07a9362ef261153d5cc4cbccd0f5f5f95446ad3f647f9cd38768bcR130).
To make matters worse, quarkusio/quarkus#57400 increased the number of this kind of warnings and now they show up across different apps in the mandrel-integration-tests (see #463).
This PR makes the whitelist patterns more generic (not package specific) and moves them under the
ALLblock, so that the related warnings are ignored on all apps.