Skip to content

Feature request: add continuous integration #11

Open
Open
Feature request: add continuous integration#11

Description

@richelbilderbeek
richelbilderbeek
opened on May 25, 2020

Dear MHCnuggets maintainer,

MHCnuggets appears awesome to me!

But without any form of continuous integration, one cannot verify if indeed everything (still) works. Also, a CI install script shows all steps needed to install and run any repo, which I find always helpful.

I would enjoy any form of continuous integration added and a juicy build badge to show everything works.

I volunteer to do so.

Activity

  1. XiaoshanShao commented on May 25, 2020

    @XiaoshanShao
    XiaoshanShao
    on May 25, 2020
    Contributor

    Hi Richel,

    Thank you for your question. I see a couple potential solutions here.

    1. It seems like your python is not recognizing your mhcnuggets's installation, that's why it is errorring out on the first step. You should probably check whether your "./bashrc" file has point your export paths to the right libraries or how your python environments are set up. For example, if you are calling one python2 environment, but mhcnuggets is installed under your python3 environment, you won't be able to call that package. You could find out more with this link here: https://stackoverflow.com/questions/53952214/how-can-i-find-out-which-python-virtual-environment-i-am-using.
    2. We built MHCnuggets mostly on python2 instead of python3. Although we built it to be indifferent to python versions, it could be one aspect of your problem (probably not the main issue here).

    Hope my answer helps you.

    Melody

  2. RachelKarchin commented on May 25, 2020

    @RachelKarchin
    RachelKarchin
    on May 25, 2020 via email
    Collaborator

  3. richelbilderbeek commented on May 25, 2020

    @richelbilderbeek
    richelbilderbeek
    on May 25, 2020
    ContributorAuthor

    Hi @XiaoshanShao: thanks for your suggestions, let's see if I can fix it now 👍

    @RachelKarchin: thanks for allowing me to make MHCnuggets even more awesome! I need nothing to get started, but I will ask to activate Travis CI (free, can login with GitHub account) when I am done. Maybe today, probably tomorrow...

  4. richelbilderbeek commented on May 25, 2020

    @richelbilderbeek
    richelbilderbeek
    on May 25, 2020
    ContributorAuthor

    Created a Pull Request (#13). It's a beginning, as there are no tests yet, which I suggest to be added in the future (#14)

  5. ctokheim commented on May 25, 2020

    @ctokheim
    ctokheim
    on May 25, 2020

    @RachelKarchin I previously added continuous integration (Travis CI) to some of my repositories (e.g., https://github.com/KarchinLab/probabilistic2020). So I believe once it is setup for mhcnuggets, then we just need to toggle it on the Travis CI website.

  6. richelbilderbeek commented on May 25, 2020

    @richelbilderbeek
    richelbilderbeek
    on May 25, 2020
    ContributorAuthor

    @ctokheim what you did there looks great! I guess that can just be copied 🙂

  7. richelbilderbeek commented on May 26, 2020

    @richelbilderbeek
    richelbilderbeek
    on May 26, 2020
    ContributorAuthor

    I submitted a stub Pull Request already that allows one to see if Travis CI is activated (#13). From that moment on, or earlier, I hope Collin works his magic 👍

  8. richelbilderbeek commented on Jun 18, 2020

    @richelbilderbeek
    richelbilderbeek
    on Jun 18, 2020
    ContributorAuthor

    @ctokheim Thanks for activating Travis CI!

    I will try to copy the .travis.yml from another one of your examples to the richel branch. If it takes me too long (say, 60 minutes), could I ask you for help?

    I know in some of my projects, those things only take minutes if you are into them 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions