Repository navigation
Migrate jenkins to gha - #158
Merged
Merged
Conversation
mscottford
reviewed
Nov 10, 2025
mscottford
left a comment
mscottford
left a comment
There was a problem hiding this comment.
The changes don't seem to line up with the PR title.
Comment on lines
-8
to
+9
| uses: jupiterone/github-internal/.github/workflows/npm-pr.yaml@v1 | ||
| secrets: inherit | ||
| uses: JupiterOne/github-internal/.github/workflows/npm-pr.yaml@v1 | ||
| secrets: inherit No newline at end of file |
There was a problem hiding this comment.
I didn't think this was case sensitive.
Comment on lines
+9
to
+10
| npm-release: | ||
| uses: jupiterone/github-internal/.github/workflows/npm-release.yaml@v1 | ||
| release: | ||
| uses: JupiterOne/github-internal/.github/workflows/npm-release.yaml@v1 |
There was a problem hiding this comment.
Is this the same job name that other projects use?
|
@tokio-on-jupiter I would revert the changes to the workflow files since the workflows referenced use the exact same paths as other projects (see). I would recommend checking instead for hidden characters if you're still seeing an issue or we need to review the upstream github-internal project and analyze the npm-pr workflow to ensure it's correct. |
ryanmcafee
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QA Checklist
Insights
index.tsfile with new boardpackage.jsonversion ex: 1.7.0 -> 1.7.1 or 1.7.0 -> 1.8.0Note: Once your changes have been merged, the owners of the insights app need to be notified