Repository navigation
feat(application): extraObjects, arbitrary manifests rendered through tpl (PLATENG-1214) - #31
Merged
Merged
Conversation
… tpl Lets an application ship the objects it depends on next to its workload (Crossplane IAM roles and pod identities, for one), ordered with sync-wave annotations. Co-authored-by: Claude <noreply@anthropic.com>
|
@tokio-on-jupiter Validation Successful |
ryanmcafee
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
query-engine-infra is moving each service's AWS identity (Crossplane IAM Role, RolePolicies and EKS PodIdentityAssociation) into that service's own Application, so a service carries everything it needs and ArgoCD orders the identity ahead of the Deployment inside one sync (ADR 0002 there). The shared chart has no way to render objects it does not know about.
What
extraObjects: [](values): each entry is a map or a YAML string, rendered throughtplin the chart's context, so{{ .Values.applicationName }}and friends work inside them.templates/extra-objects.yaml, README row, 2 unit tests. Nothing renders unless the list is set; existing renders are byte-identical.