Repository navigation
feat(application): KEDA trigger fields, fallback and ServiceMonitor name (PLATENG-1306) - #30
Merged
Merged
Conversation
…lback, ServiceMonitor name scalingModifiers formulas reference triggers by name, and a prometheus trigger has no AWS identity to assume, so a trigger can now opt out of authenticationRef. fallback passes through like advanced. ServiceMonitor gets a name override so an adopted monitor keeps its live name. Co-authored-by: Claude <noreply@anthropic.com>
|
@tokio-on-jupiter Validation Successful |
ryanmcafee
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
query-engine #2391 gives executor a two-trigger KEDA ScaledObject (SQS backlog plus a Prometheus Neo4j queue-depth gate) combined by a
scalingModifiersformula, with afallback, and a ServiceMonitor namedexecutor. The chart could not express three parts of that: triggers had noname/metricType/useCachedMetrics, every trigger was forced to carryauthenticationRef(a prometheus trigger has none),fallbackwas not rendered, and the ServiceMonitor name was fixed to<name>-svc-monitor.What
keda.triggers[]:name,metricType,useCachedMetricsemitted when set;authenticationRef: falseomits the reference for that trigger (string still overrides the name, default unchanged).keda.fallback: passed through likeadvanced.serviceMonitor.name: optional override.Consumed by query-engine-infra to mirror the executor autoscaler (PLATENG-1306); pin bump there follows the release.