Repository navigation
fix(release): push the version bump without rewriting the origin remote - #26
Merged
Merged
Conversation
chart-releaser derives its gh-pages push URL from origin (pkg/git/git.go GetPushURL: git remote get-url --push, then prefixes https://x-access-token:<token>@). Since #23 moved the bump commit ahead of publishing, the bump step's remote set-url left a token inside origin, so chart-releaser produced token@token@github.com and git failed with "URL rejected: Port number was not a decimal number" (run 35279850618, after application-1.1.1 and its tag were already published). The bump is now pushed through an explicit URL and origin is never modified. Co-authored-by: Claude <noreply@anthropic.com>
|
@ryanmcafee Validation Successful |
ryanmcafee
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Run 35279850618 (the first release after #25) got further than any run before it:
Chart.yamlbumped to 1.1.1 and committed,v1.1.1tagged,application-1.1.1published with.tgzand.prov. It then failed inside chart-releaser at thegh-pagesindex push:Cause: the bump step ran
git remote set-url origin https://x-access-token:<token>@github.com/...so it could push, and since #23 moved that step ahead of publishing, chart-releaser now sees the rewritten remote. chart-releaser v1.6.1 builds its push URL from origin (pkg/git/git.goGetPushURL:git remote get-url --push origin, split afterhttps://, prefixhttps://x-access-token:<CR_TOKEN>@). With a token already in origin the result isand curl parses
TOKEN@github.comas a port number. Before #23 chart-releaser ran first and never saw the rewritten remote, which is why this never surfaced.What
The bump step pushes through an explicit URL (
git push "https://x-access-token:${TOKEN}@github.com/${GITHUB_REPOSITORY}.git" HEAD:main) and leavesoriginuntouched. Nothing else changes.Verification
curl 'https://x-access-token:abc@x-access-token:abc@github.com/'returnscurl: (3) URL rejected: Port number was not a decimal number between 0 and 65535, the same message as the run.catthehacker/ubuntu:act-latest, Ubuntu 24.04) viaact: an explicit-URLgit push --dry-runagainst this repository succeeds withoriginleft athttps://github.com/JupiterOne/apps-helm-charts, andcr index(without--push) generates the index normally against that origin.After merge
GitVersion resolves 1.1.2 from the
v1.1.1tag, the bump and tag land, chart-releaser publishesapplication-1.1.2and rebuildsgh-pages/index.yamlfrom all releases, which also adds the missing 1.1.0 and 1.1.1 entries. No manual repair needed.