Draft
Conversation
Co-authored-by: tika <tika@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#209 #209
Who worked on this sprint/bug?
Cursor cloud agent
Who did what on this sprint/bug?
Implemented server-side Zod validation for all routes listed in the issue, replacing manual validation logic where needed and preserving existing route behavior.
Features Implemented
/api/uploadPOST payload, includingformYear,formData,schoolCoordinates, andschoolInfoDataJSON parsing/shape checks./api/projects/[id](id,title,category,categoryId,division,teamProject,numStudents)/api/teachers/[id](id,name,email)/api/schools/[name](nameparam,yearfor yearly fields, and body fields for location/name/city/metadata updates)/api/schools(year,list,gateway)/api/schools/[name](year)/api/heat-layer(corresponding to heatmap endpoint in current codebase) (year)/api/years-with-data(school,simple)/api/yearly-totals(year)/api/delete-year(corresponding to year delete endpoint in current codebase) (year)New files created
Existing files modified
src/app/api/upload/route.tssrc/app/api/projects/[id]/route.tssrc/app/api/teachers/[id]/route.tssrc/app/api/schools/[name]/route.tssrc/app/api/schools/route.tssrc/app/api/heat-layer/route.tssrc/app/api/years-with-data/route.tssrc/app/api/yearly-totals/route.tssrc/app/api/delete-year/route.tsAcceptance Criteria
Testing: how did you test?
npm run lintFeatures Not Implemented/Incomplete
/api/heat-layer,/api/delete-year) that correspond functionally to issue targets.Bugs Discovered
Screenshots:
Tag Dan and Shayne
@danglorioso @shaynesidman