Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#186
Who worked on this sprint/bug?
Chiara
Features Implemented
In PDF exports, the actual parameters that were selected within a chart export are now listed underneath the exported graph.
New files created
None
Existing files modified
src/app/chart/page.tsx
src/lib/export-to-pdf.ts
src/components/Cart.tsx
Acceptance Criteria
Parameters used to filter the graph are now displayed below the graph when exported
Testing: how did you test?
Changed filters for the line and bar charts, exported the graphs separately and also grouped in the cart, made sure correct info was displayed under the graphs properly.
I also didn't add text below the heat map because I realized that all the filter info is already included in the title, but lmk if I should add something to this.
Features Not Implemented/Incomplete
Bugs Discovered
One thing I noticed is after downloading many graphs, sometimes when I click the download button, I get a confirmation that the pdf was downloaded when it actually wasn't. If I refresh the page, it works properly. I didn't fix this and it happens inconsistently.
Screenshots:
Tag Dan and Shayne
@danglorioso @shaynesidman