Repository navigation
Avoid duplicate function evaluation in hybrid methods - #532
Merged
Merged
Conversation
Only re-evaluate the function in the hybrid solve! when the proposed step was adjusted; otherwise update_state has already computed it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #532 +/- ##
==========================================
+ Coverage 86.80% 86.84% +0.04%
==========================================
Files 43 43
Lines 2697 2698 +1
==========================================
+ Hits 2341 2343 +2
+ Misses 356 355 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Thanks so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #531.
After
update_state, the hybridsolve!re-evaluatedFat the proposed point even when the step was not adjusted. Now it only re-evaluates when the step was shortened or lengthened. Adds a regression test that no point is evaluated twice in a row.🤖 Generated with Claude Code