Skip to content

fix spelling, close issue #526 - #527

Merged
jverzani merged 3 commits into
JuliaMath:masterfrom
jverzani:chandrupatla
Sep 1, 2026
Merged

jverzani merged 3 commits into
JuliaMath:masterfrom
jverzani:chandrupatla

Conversation

@jverzani

@jverzani jverzani commented Sep 1, 2026

Copy link
Copy Markdown
Member

Fix spelling of method name. Close #526

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Documentation still contains references to a non-existent Roots.Chandrupatlu symbol and a few fixable typos introduced in the edited lines.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR addresses Issue #526 by correcting the spelling of the Chandrupatla bracketing method name across the library, tests, and documentation, while keeping backward compatibility for the old misspelling.

Changes:

  • Renames the public method type usage from Chandrapatla to Chandrupatla (and updates tests/docs accordingly).
  • Updates the bracketing implementation file/include to the corrected filename and adds an alias for the old misspelling.
  • Bumps patch version from 3.0.7 to 3.0.8.
File summaries
File Description
test/test_jet.jl Updates method list to use Roots.Chandrupatla()
test/test_bracketing.jl Updates bracketing method tuples to use Roots.Chandrupatla()
src/Roots.jl Updates include to Bracketing/chandrupatlu.jl
src/Bracketing/chandrupatlu.jl Renames method/state types and keeps Chandrapatla as an alias
Project.toml Patch version bump to 3.0.8
docs/src/roots.md Updates tutorial text/examples to Chandrupatla
docs/src/refs.bib Updates section heading spelling for the reference
docs/src/reference.md Updates reference listing to Roots.Chandrupatla
docs/src/index.md Updates method list in docs index (currently has a remaining incorrect symbol)
docs/src/geometry-zero-finding.md Updates narrative example (currently has a remaining incorrect symbol)
Review details

Suppressed comments (1)

src/Bracketing/chandrupatlu.jl:14

  • Spelling in comment: “mis-spelling” should be “misspelling”.
  • Files reviewed: 9/10 changed files
  • Comments generated: 4
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/src/geometry-zero-finding.md Resolved
Comment thread docs/src/index.md Resolved
Comment thread docs/src/refs.bib Resolved
Comment thread docs/src/roots.md Resolved
@codecov

codecov Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.80%. Comparing base (5b4857a) to head (2e74c3f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #527   +/-   ##
=======================================
  Coverage   86.80%   86.80%           
=======================================
  Files          43       43           
  Lines        2697     2697           
=======================================
  Hits         2341     2341           
  Misses        356      356           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jverzani
jverzani merged commit e1607e5 into JuliaMath:master Sep 1, 2026
12 of 15 checks passed
@jverzani
jverzani deleted the chandrupatla branch September 1, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename Chandrapatla to Chandrupatla

2 participants