Remove macOS 14 support - #942
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #942 +/- ##
==========================================
+ Coverage 86.72% 86.80% +0.08%
==========================================
Files 77 77
Lines 5485 5481 -4
==========================================
+ Hits 4757 4758 +1
+ Misses 728 723 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
christiangnrd
removed this pull request from stack #943
September 9, 2026 23:02
christiangnrd
added this pull request to stack #958
September 9, 2026 23:44
christiangnrd
force-pushed
the
no14
branch
4 times, most recently
from
September 14, 2026 22:44
a1b834e to
2f937b8
Compare
christiangnrd
marked this pull request as ready for review
September 14, 2026 23:08
Contributor
There was a problem hiding this comment.
Metal Benchmarks
Details
| Benchmark suite | Current: 6df0a24 | Previous: 8fe5ff3 | Ratio |
|---|---|---|---|
array/accumulate/Float32/1d |
388916 ns |
392083 ns |
0.99 |
array/accumulate/Float32/dims=1 |
367375 ns |
368625 ns |
1.00 |
array/accumulate/Float32/dims=1L |
8768750 ns |
8771834 ns |
1.00 |
array/accumulate/Float32/dims=2 |
429125 ns |
432166 ns |
0.99 |
array/accumulate/Float32/dims=2L |
2527875 ns |
2019667 ns |
1.25 |
array/accumulate/Int64/1d |
809750 ns |
807750 ns |
1.00 |
array/accumulate/Int64/dims=1 |
908167 ns |
908875 ns |
1.00 |
array/accumulate/Int64/dims=1L |
9455041 ns |
9451333 ns |
1.00 |
array/accumulate/Int64/dims=2 |
1210791 ns |
1049875 ns |
1.15 |
array/accumulate/Int64/dims=2L |
6409750 ns |
6410375 ns |
1.00 |
array/broadcast |
229208 ns |
229084 ns |
1.00 |
array/construct |
2292 ns |
2250 ns |
1.02 |
array/permutedims/2d |
435375 ns |
435542 ns |
1.00 |
array/permutedims/3d |
996875 ns |
998542 ns |
1.00 |
array/permutedims/4d |
1083000 ns |
996834 ns |
1.09 |
array/private/copy |
227167 ns |
228709 ns |
0.99 |
array/private/copyto!/cpu_to_gpu |
212375 ns |
213917 ns |
0.99 |
array/private/copyto!/gpu_to_cpu |
212417 ns |
216750 ns |
0.98 |
array/private/copyto!/gpu_to_gpu |
219417 ns |
220708 ns |
0.99 |
array/private/iteration/findall/bool |
1036792 ns |
1030750 ns |
1.01 |
array/private/iteration/findall/int |
1204417 ns |
1206833 ns |
1.00 |
array/private/iteration/findfirst/bool |
1133291 ns |
1144541 ns |
0.99 |
array/private/iteration/findfirst/int |
1151541 ns |
1150584 ns |
1.00 |
array/private/iteration/findmin/1d |
1206208 ns |
1201166 ns |
1.00 |
array/private/iteration/findmin/2d |
1029500 ns |
1025458 ns |
1.00 |
array/private/iteration/logical |
1629291 ns |
1636291 ns |
1.00 |
array/private/iteration/scalar |
1379584 ns |
1406292 ns |
0.98 |
array/random/rand/Float32 |
416750 ns |
412000 ns |
1.01 |
array/random/rand/Int64 |
493833 ns |
495041 ns |
1.00 |
array/random/rand!/Float32 |
332708 ns |
404417 ns |
0.82 |
array/random/rand!/Int64 |
429250 ns |
420458 ns |
1.02 |
array/random/randn/Float32 |
388000 ns |
389333 ns |
1.00 |
array/random/randn!/Float32 |
376334 ns |
375958 ns |
1.00 |
array/reductions/mapreduce/Float32/1d |
449416 ns |
440250 ns |
1.02 |
array/reductions/mapreduce/Float32/dims=1 |
355083 ns |
355416 ns |
1.00 |
array/reductions/mapreduce/Float32/dims=1L |
603500 ns |
619292 ns |
0.97 |
array/reductions/mapreduce/Float32/dims=2 |
357583 ns |
360625 ns |
0.99 |
array/reductions/mapreduce/Float32/dims=2L |
1218917 ns |
1239958 ns |
0.98 |
array/reductions/mapreduce/Int64/1d |
615750 ns |
545167 ns |
1.13 |
array/reductions/mapreduce/Int64/dims=1 |
637583 ns |
637833 ns |
1.00 |
array/reductions/mapreduce/Int64/dims=1L |
1011708 ns |
1010083 ns |
1.00 |
array/reductions/mapreduce/Int64/dims=2 |
789084 ns |
792000 ns |
1.00 |
array/reductions/mapreduce/Int64/dims=2L |
2194666 ns |
2206167 ns |
0.99 |
array/reductions/reduce/Float32/1d |
436000 ns |
441125 ns |
0.99 |
array/reductions/reduce/Float32/dims=1 |
355042 ns |
352375 ns |
1.01 |
array/reductions/reduce/Float32/dims=1L |
611000 ns |
613083 ns |
1.00 |
array/reductions/reduce/Float32/dims=2 |
235208 ns |
246166 ns |
0.96 |
array/reductions/reduce/Float32/dims=2L |
484375 ns |
487375 ns |
0.99 |
array/reductions/reduce/Int64/1d |
638167 ns |
609250 ns |
1.05 |
array/reductions/reduce/Int64/dims=1 |
635500 ns |
642125 ns |
0.99 |
array/reductions/reduce/Int64/dims=1L |
1010208 ns |
1006167 ns |
1.00 |
array/reductions/reduce/Int64/dims=2 |
268875 ns |
267875 ns |
1.00 |
array/reductions/reduce/Int64/dims=2L |
672875 ns |
674542 ns |
1.00 |
array/shared/copy |
130583 ns |
128250 ns |
1.02 |
array/shared/copyto!/cpu_to_gpu |
38083 ns |
36917 ns |
1.03 |
array/shared/copyto!/gpu_to_cpu |
37833 ns |
36458 ns |
1.04 |
array/shared/copyto!/gpu_to_gpu |
38208 ns |
36875 ns |
1.04 |
array/shared/iteration/findall/bool |
1029708 ns |
1032416 ns |
1.00 |
array/shared/iteration/findall/int |
1204208 ns |
1203542 ns |
1.00 |
array/shared/iteration/findfirst/bool |
908208 ns |
965042 ns |
0.94 |
array/shared/iteration/findfirst/int |
982292 ns |
980167 ns |
1.00 |
array/shared/iteration/findmin/1d |
1055000 ns |
1063709 ns |
0.99 |
array/shared/iteration/findmin/2d |
1033584 ns |
1036458 ns |
1.00 |
array/shared/iteration/logical |
1496167 ns |
1501792 ns |
1.00 |
array/shared/iteration/scalar |
3812.5 ns |
3854.125 ns |
0.99 |
array/sorting/1d |
2099792 ns |
2099959 ns |
1.00 |
array/sorting/2d |
8337042 ns |
8336791 ns |
1.00 |
integration/byval/reference |
1120291 ns |
1113916 ns |
1.01 |
integration/byval/slices=1 |
1122958 ns |
1107125 ns |
1.01 |
integration/byval/slices=2 |
2015583 ns |
2033875 ns |
0.99 |
integration/byval/slices=3 |
6439375 ns |
6550917 ns |
0.98 |
integration/metaldevrt |
390250 ns |
392292 ns |
0.99 |
kernel/indexing |
211500 ns |
215125 ns |
0.98 |
kernel/indexing_checked |
391667 ns |
393375 ns |
1.00 |
kernel/launch |
1791.7 ns |
1816.6 ns |
0.99 |
kernel/rand |
335041 ns |
403291 ns |
0.83 |
latency/import |
1778898583 ns |
1785689000 ns |
1.00 |
latency/precompile |
26084902042 ns |
26156114458 ns |
1.00 |
latency/ttfp |
2276033417 ns |
2284072959 ns |
1.00 |
metal/synchronization/context |
558.5989304812834 ns |
547.6190476190476 ns |
1.02 |
metal/synchronization/stream |
346.4537037037037 ns |
356.52358490566036 ns |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
maleadt
approved these changes
Sep 16, 2026
maleadt
left a comment
Member
There was a problem hiding this comment.
Conceptually LGTM; I didn't review the diff in detail.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Only precompile on supported macOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.