Repository navigation
Conversation
`BenchmarkTools` v1.7+ changed the signature of its generated `##sample#` functions, which breaks `PkgJogger` v0.6.0's `@test_benchmarks` with a `MethodError` and fails the Benchmarks CI group. Cap the test and benchmark environments at `~1.6` until `PkgJogger` supports newer `BenchmarkTools` releases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
+ Coverage 85.74% 93.76% +8.02%
==========================================
Files 28 28
Lines 1087 1090 +3
==========================================
+ Hits 932 1022 +90
+ Misses 155 68 -87 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adrhill
changed the title
BenchmarkTools compat at v1.6v1.6
adrhill
changed the title
v1.6v1.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing
BenchmarksCI group onmain.BenchmarkToolsv1.7+ changed the signature of its internally generated##sample#functions, which breaksPkgJoggerv0.6.0's@test_benchmarkswith aMethodError. The last green run onmainresolvedBenchmarkToolsv1.6.3; the first red one resolved v1.8.0 with no other relevant version changes.BenchmarkToolsat~1.6intest/Project.tomlandbenchmark/Project.tomluntilPkgJoggersupports newerBenchmarkToolsreleases.🤖 Generated with Claude Code