ci: standardize linting, import hygiene, and CI workflows - #196
Merged
Conversation
…Formatter config - Move the Aqua.jl and JET.jl checks from `test/runtests.jl` into a self-contained `test/linting.jl` (JET runs on Julia v1.12+ only). - Remove the unused `.JuliaFormatter.toml`; formatting is enforced by the Runic CI job. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
adrhill
changed the title
`(s::AugmentationSelector)(out)` used an untyped argument, making it ambiguous with XAIBase's `(::AbstractOutputSelector)(::AbstractVector)` guard whenever the output is a vector. Specialize on `::AbstractMatrix` to match the other concrete selectors (MaxActivationSelector, IndexSelector) and preserve the missing-batch-dimension guard. Surfaced by the new package-scoped Aqua.test_ambiguities check. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add `Aqua.test_ambiguities(<Module>)` alongside the existing `Aqua.test_all(...; ambiguities = false)`. test_all's built-in check broadens to [Module, Core, Base] and trips on dependency-owned ambiguities we can't fix; the scoped call only reports ambiguities where at least one conflicting method is owned by the package itself. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pin all GitHub Actions to their latest major moving tag: checkout@v7, setup-julia@v3, cache@v3, codecov-action@v7 (julia-actions/*, TagBot and runic-action stay @v1). The codecov bump is input-safe as every step already uses the post-v4 `files:` schema. Test only on Julia '1' and 'lts' on a single ubuntu-latest runner: drop 'pre'/'nightly'/pinned point releases and remove the os/arch matrix dimensions and hardcoded arch inputs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
adrhill
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/linting.jl(JET runs on Julia v1.12+ only).Aqua.test_ambiguitiescheck alongsideAqua.test_all(…; ambiguities = false).AugmentationSelectorsurfaced by that check (narrow its call signature toAbstractMatrix).1andlts, and drop theos/archmatrix (singleubuntu-latestrunner)..JuliaFormatter.toml(formatting is enforced by the Runic CI job) and add a pre-commit config (Runic, typos, whitespace/EOF hygiene).🤖 Generated with Claude Code