Fix import when object exists but is not in view layer - #583
Closed
combwizard wants to merge 2 commits into
Closed
combwizard wants to merge 2 commits into
combwizard wants to merge 2 commits into
Conversation
make_mesh() only linked new objects to a collection. Re-importing by name updated orphan or excluded objects without re-linking them, so select_set() crashed.
Map _low2/_low3 names to canonical _low meshes, sync low collections from matching _high objects, remove stale variants, and guard face-set assignment when polygroup counts diverge. Document fork setup and fixes.
Collaborator
|
Hello, I've included a version of the changes proposed in your initial commit. The changes in your second commit should definitely be a new PR with some details on exactly how it is meant to work. The current implementation seems like it would be quite easy for a user who is not familiar with its function to have their meshes overwritten or deleted unintentionally. It would probably need to be something that can be enabled and configured from the settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: export mesh via GoB, delete from scene (datablock remains), GoZ back, Manual Import.
Error: select_set fails, object not in View Layer.
make_mesh() only linked new objects to a collection. Updates to existing datablocks skipped re-linking.
Adds _ensure_object_in_view_layer() to link orphan/excluded objects into Scene Collection before select_set.