Repository navigation
[SYMPP-HERDR-NEXT] Closed-out packages and WorkRequests read as done - #786
Merged
Merged
Conversation
Derive request execution closure without changing stored planning status or treating abandoned scope as fulfilled. Clear terminal merge actions and return actionable reconciliation rows with a full evidence option. Update the native Done phase, dropped counts, MCP identity and Skills. Validation: 36 focused ExUnit tests, 84 native integration tests plus the new rendered closure case; format, strict Credo and portable mirror. Co-authored-by: Codex <codex@openai.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Count terminal abandonment without a closeout as dropped. Closed raw packages remain Closed; the request brief reports closure rather than inventing successful delivery. Cover missing-closeout native input. Validation: all 85 native integration tests passed; native check passed. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Finished requests still looked active and reconciliation repeated every closed package.
TL;DR
Show closed execution as Done and keep reconciliation focused on actionable rows.
Summary
Alternatives
Test Plan
make -C elixir all— local aggregate not run; assigned full qualification is hosted.make -C elixir ci-full— local aggregate not run; all hosted qualification gates passed.Acceptance evidence: a 25-package mixed terminal fixture retains all 25 full rows and nested evidence.
Previous public reconciliation JSON: 4,756 characters; new default: 160 (96.6% smaller).
The new full format is 4,848 characters and keeps all 25 rows. Summary keeps every count.
Raw terminal abandonment without a delivery record remains dropped, and closed briefs make no fulfillment claim.
Reads agree on
execution_status: closedwhile rawstatus: slicedand unfulfilled abandoned scope remain.CI: https://github.com/JJLiebig/symphony-plus-plus/actions/runs/40315268208
Runtime builds: https://github.com/JJLiebig/symphony-plus-plus/actions/runs/40315268169
Review: rvw_4b7a188a fast, complete on bd95ca5 after validated P2 fixes.
Upgrade: refresh Skills and start fresh MCP sessions. Installed runtime and live ledger are untouched.
WorkPackage: wp_i6xwzgpfaauzn5hj. Do not merge; parent owns reconciliation.