Repository navigation
Conversation
R_SetupEntityLightingGrid in rd-rend2 still carries the PowerPC fast path inherited from Quake 3, where the light grid was a plain byte array and the six samples were copied into locals before use. In OpenJK the grid is an array of mgrid_t, so on PowerPC the idppc branch assigns whole structs to floats and the renderer does not compile: codemp/rd-rend2/tr_light.cpp:213:8: error: assigning to 'float' from incompatible type 'mgrid_t' Remove the idppc branch and use the generic mgrid_t code on every architecture, as rd-vanilla already does. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R_SetupEntityLightingGrid in rd-rend2 still carries the PowerPC fast
path inherited from Quake 3, where the light grid was a plain byte
array and the six samples were copied into locals before use. In
OpenJK the grid is an array of mgrid_t, so on PowerPC the idppc branch
assigns whole structs to floats and the renderer does not compile:
codemp/rd-rend2/tr_light.cpp:213:8: error: assigning to 'float' from
incompatible type 'mgrid_t'
Remove the idppc branch and use the generic mgrid_t code on every
architecture, as rd-vanilla already does.
Co-Authored-By: Claude Fable 5.1 noreply@anthropic.com