coot/node kernel cleanup#35
Open
coot wants to merge 4 commits into
Open
Conversation
coot
force-pushed
the
coot/node-kernel-cleanup
branch
from
dd4c0bf to
b936c88
Compare
coot
force-pushed
the
coot/node-kernel-cleanup
branch
from
b936c88 to
d1fa5d3
Compare
Based on `coot/tracing-instances-1` branch from `ouroboros-network`. To use `main` branch we need to wait for `cardano-crypto-class`, `ouroboros-consensus`, `kes-agent-crypto` to support `contra-tracer-0.2.1.0`.
Removed the case where we validate signatures based on mark set. Now signatures validation fails with `SigExipred` only in the `ZeroSetSnapshot` case. Because of that also the other case where `ssMarkSet` was used becomes obsolete, and thus we don't use the mark set at all. If a pool reaches zero stake in epoch `i`, then it will still get rewards in the epochs `i+1` and `i+2`, so there's nothing wrong allowing it to mint signatures in the epoch `i+1`, e.g. there's a natural inertia in the system based on trust in the stake snapshots.
coot
force-pushed
the
coot/node-kernel-cleanup
branch
from
d1fa5d3 to
dc9d778
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires: