fix: validate embedded TIFF profiles - #1752
Merged
Merged
Conversation
xsscx
force-pushed
the
ci-qa-cli-icctiffdump-spectral-mismatch
branch
from
July 21, 2026 15:59
9c26f35 to
0676110
Compare
xsscx
force-pushed
the
ci-qa-cli-icctiffdump-spectral-mismatch
branch
from
July 21, 2026 17:52
0676110 to
4ec01df
Compare
Member
Author
Test PR 1752 with the iccDEV Regression ContainerRun these one-line commands on the host: IMAGE=ghcr.io/internationalcolorconsortium/iccdev-ci-regression:sha-750f43102b58cb60dbc9eaa253b3d336757530cb
docker pull "$IMAGE"
docker image inspect "$IMAGE" --format '{{index .RepoDigests 0}} revision={{index .Config.Labels "org.opencontainers.image.revision"}}'
docker run --rm -it "$IMAGE" bashRun these one-line commands inside the container: set -euo pipefail
cd /workspace/iccDEV
git fetch --depth=1 origin pull/1752/head:pr-1752
git checkout pr-1752
cd Build
git branch && echo "---" && git log --oneline -1
SAN_FLAGS='-fsanitize=address,undefined,integer,bounds,null,float-divide-by-zero,alignment,vla-bound -fno-omit-frame-pointer -g -O0'
CC=clang CXX=clang++ CFLAGS="$SAN_FLAGS" CXXFLAGS="$SAN_FLAGS" LDFLAGS='-fsanitize=address,undefined,integer,bounds,null,float-divide-by-zero,alignment,vla-bound -Wl,--build-id' cmake Cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_ASAN=ON -DENABLE_UBSAN=ON -DSANITIZER_RECOVER=ON -DENABLE_TOOLS=ON -DENABLE_TESTS=ON -DENABLE_WXWIDGETS=OFF -Wno-dev
cmake --build . --parallel 32
cmake --build . --target build-test-binaries --parallel 32
cd ../Testing
for d in ../Build/Tools/*; do [ -d "$d" ] && export PATH="$(realpath "$d"):$PATH"; done
printf '%s\n%s\n%s\n' 'unsigned-integer-overflow:*/IccMD5.cpp' 'shift-base:*/IccMD5.cpp' 'shift-exponent:*/IccMD5.cpp' > silence.txt
export ASAN_OPTIONS='print_scariness=1:halt_on_error=1:detect_leaks=0'
export UBSAN_OPTIONS="halt_on_error=0:suppressions=$PWD/silence.txt"
./CreateAllProfiles.sh
./RunTests.sh
(cd HDR && ./mkprofiles.sh)
(cd Display && ./RunProtoTests.sh)
(cd hybrid && ./BuildAndTest.sh)
(cd CalcTest && ./checkInvalidProfiles.sh)
(cd mcs && ./updateprev.sh)
(cd mcs && ./updateprevWithBkgd.sh)
ctest --test-dir ../Build --output-on-failure --no-tests=errorThe immutable image tag keeps the container toolchain reproducible. To test the IMAGE=ghcr.io/internationalcolorconsortium/iccdev-ci-regression:latest |
xsscx
force-pushed
the
ci-qa-cli-icctiffdump-spectral-mismatch
branch
from
July 21, 2026 19:29
4ec01df to
eb4fc34
Compare
xsscx
force-pushed
the
ci-qa-cli-icctiffdump-spectral-mismatch
branch
from
July 21, 2026 20:45
eb4fc34 to
c88d1b3
Compare
ChrisCoxArt
approved these changes
Jul 21, 2026
Member
Author
Bisect2026-08-17 16:17:00 UTC Note: Living off the Land PoC
Merge DefectBisect: 800ac41 TIFF Read regression for recursive tag loading & validation Identification Method
Resolution
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
#1678
Checklist
docs/build.mddocs/ctest.mddocs/python-packaging-release.mdfor PR and merge requirementsm_membersLegal Requirements
All official software projects hosted by the International Color Consoritum (ICC)
follows the open source software best practice policies. The International Color Consoritum IP policy governs ICC specification development and contributions to ICC open source software. Software contributions are also covered by the Contributor License Agreement (CLA).
Contributor License Agreements
Developers who wish to contribute code to be considered for inclusion
in ICC software must first complete a Contributor License Agreement
(CLA).
There is no cost or membership requirement to sign the ICC Contributor License Agreement (CLA). Please note that this is different from membership in the International Color Consortium (ICC). If your organization relies on our projects, please become a member. Membership dues are an essential source of funding and investment for these projects.
If you are an individual writing the code on your own time and you are SURE you are the sole owner of any intellectual property you contribute, you can sign the CLA as an individual contributor.
If you are writing the code as part of your job, or if there is any possibility that your employer might think they own any intellectual property you create, then you should use the Corporate Contributor Licence Agreement
License
ICC software is licensed under the BSD 3-Clause "New" or "Revised" License. Contributions to ICC software projects should abide by that license unless otherwised specified or approved by the ICC.
Copyright Notices
All new source files must begin with the ICC Copyright notice and include or reference the BSD 3-Clause "New" or "Revised" License.
INTELLECTUAL PROPERTY & PATENTS
Participation in ICC's development activities is subject to ICC's Patent Policy.
Maintainer Review Required
If you have questions, contact a listed Maintainer.